Skip to content

chore: Remove deprecated protobuf fields#10155

Merged
mraszyk merged 2 commits into
dfinity:masterfrom
dsarlis:dimitris/remove-proto-fields
May 11, 2026
Merged

chore: Remove deprecated protobuf fields#10155
mraszyk merged 2 commits into
dfinity:masterfrom
dsarlis:dimitris/remove-proto-fields

Conversation

@dsarlis
Copy link
Copy Markdown
Contributor

@dsarlis dsarlis commented May 11, 2026

Several fields regarding storing Cycles prepayments are now obsolete after introducing new versions of them that deal with CompoundCycles. The relevant code has been deployed to production for a couple weeks already so we can now remove the fallback code that was trying to backfill data from the old fields.

Additionally, we make the parsing code for a new field prepayment_for_call_transmission that was introduced stricter as it should also be populated now in production.

@dsarlis dsarlis requested a review from a team as a code owner May 11, 2026 07:10
@github-actions github-actions Bot added the chore label May 11, 2026
Comment thread rs/protobuf/def/state/canister_state_bits/v1/canister_state_bits.proto Outdated
Comment thread rs/types/types/src/methods.rs
@basvandijk basvandijk added the security-review-passed IDX or InfraSec have concluded it's safe to run CI on the external PR. label May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Comment thread rs/replicated_state/src/canister_state/system_state/proto.rs
@dsarlis dsarlis requested a review from mraszyk May 11, 2026 09:08
@dsarlis
Copy link
Copy Markdown
Contributor Author

dsarlis commented May 11, 2026

Run on f49d15b URL: https://github.com/dfinity/ic/actions/runs/25655953578

I noticed a failure for some system tests which seem to have failed due to:

failed to setup IC under test: Retried too many times: sending a request to Farm

and one which failed with

-- could not kill VM: TooManyRetries { message: "sending a request to Farm" }

so I would assume it's due to flakiness.

@github-actions
Copy link
Copy Markdown
Contributor

@mraszyk mraszyk enabled auto-merge May 11, 2026 09:14
@dsarlis
Copy link
Copy Markdown
Contributor Author

dsarlis commented May 11, 2026

@mraszyk Can you please retry this job? It seems there was some issue downloading certain dependencies...

@mraszyk mraszyk added this pull request to the merge queue May 11, 2026
Merged via the queue into dfinity:master with commit b273013 May 11, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore external-contributor security-review-passed IDX or InfraSec have concluded it's safe to run CI on the external PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants