chore: Remove NonConsumed cycles use case#10154
Merged
alin-at-dfinity merged 2 commits intoMay 11, 2026
Merged
Conversation
basvandijk
added
the
security-review-passed
Contributor
alin-at-dfinity
previously approved these changes
May 11, 2026
Contributor
alin-at-dfinity
left a comment
alin-at-dfinity
left a comment
There was a problem hiding this comment.
LGTM, thank you.
Contributor
|
Looks like the |
auto-merge was automatically disabled
May 11, 2026 09:26
Head branch was pushed to by a user without write access
github-actions
Bot
dismissed
alin-at-dfinity’s stale review
Review dismissed by automation script.
Contributor
Author
Makes sense. I updated the test to remove the missing variant's value from the expected result which should be fine given that it was never serialized (and so it never needs to be deserialized) by the implementation. |
alin-at-dfinity
approved these changes
May 11, 2026
Contributor
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
NonConsumeduse case is no longer needed after previous refactorings of the code that more clearly separated the cases using an approach with generics. TheNonConsumedwas mainly meant to mark cases which should not be tracked in canister metrics (e.g. transfers of cycles from one canister to another which are not consumed), however, this is now obsolete as is obvious from the code removed, there were a couple ofdebug_asserts verifying that this variant is not present and it appeared in some match statements due to compilation requirements.Removing the variant from the protobuf enum should also be safe as it should not be present in any checkpoint files.