fix: update mypy type-ignore code in dem algorithm to [call-overload]#1449
Open
wakame1367 wants to merge 1 commit into
Open
fix: update mypy type-ignore code in dem algorithm to [call-overload]#1449wakame1367 wants to merge 1 commit into
wakame1367 wants to merge 1 commit into
Conversation
The numpy typing stubs now report the masked-array assignment as a [call-overload] error instead of [index], leaving the existing `# type: ignore [index]` comments uncovered and breaking the mypy CI step. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The mypy CI step is currently failing on
main(and therefore on every open PR)because the numpy typing stubs now report the masked-array assignments in the
DEM algorithms as
[call-overload]errors instead of[index]:The existing
# type: ignore [index]comments no longer cover the reportederror code, so mypy fails.
This PR updates the two ignore comments to
[call-overload]to match the codenumpy now emits. No runtime behavior changes.
Changes
titiler/core/algorithm/dem.py:# type: ignore [index]-># type: ignore [call-overload](lines 182 and 242)I noticed this while working on #1448 — the failure is unrelated to that PR and
pre-existing on
main(e.g. the CI run for the merge commit on main also failswith the same two
dem.pyerrors).🤖 Generated with Claude Code