Open
Conversation
Previously V8 patches were managed in a separate denoland/v8 repo with its own autoroll script and CI job. This required coordinating two repos and two cron jobs just to apply patches on top of upstream V8. Now everything lives in rusty_v8: - patches/ directory contains the V8 patch files - tools/auto_update_v8.ts fetches upstream V8 directly, applies patches, pushes to the denoland/v8 fork, and updates rusty_v8 deps — all in one step - Single cron job instead of two To add a new patch: drop a .patch file in patches/ To bump V8 version: change V8_VERSION at the top of auto_update_v8.ts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
denoland/v8repo intopatches/directory in this repotools/auto_update_v8.tsto be a single unified script that fetches upstream V8 directly, applies patches, pushes to the denoland/v8 fork, and updates all depsdenoland/v8's separate autoroll cron jobPreviously managing V8 patches required coordinating two repos (
denoland/v8anddenoland/rusty_v8) with two separate cron jobs. Cherry-picking a commit or adding a patch meant working indenoland/v8first, waiting for its autoroll to run, then waiting forrusty_v8's autoroll to pick it up.Now:
.patchfile inpatches/V8_VERSIONat the top ofauto_update_v8.tspatches/The
denoland/v8repo remains as a submodule host but its autoroll workflow can be disabled.Test plan
deno run -A ./tools/auto_update_v8.tsworks end-to-enddenoland/v8after merging🤖 Generated with Claude Code