Skip to content
This repository was archived by the owner on Apr 2, 2026. It is now read-only.

fix: event loop rewrite and libuv compat layer#1309

Merged
nathanwhit merged 25 commits intomainfrom
event-loop-rewrite-slop
Feb 26, 2026
Merged

fix: event loop rewrite and libuv compat layer#1309
nathanwhit merged 25 commits intomainfrom
event-loop-rewrite-slop

Conversation

@littledivy
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

Comment thread core/01_core.js
Comment thread core/01_core.js
Comment thread core/runtime/jsruntime.rs Outdated
Comment thread core/runtime/jsruntime.rs
Comment thread core/reactor.rs
@nathanwhit nathanwhit force-pushed the event-loop-rewrite-slop branch from 75ab1f3 to 0c40092 Compare February 24, 2026 02:56
Comment thread core/uv_compat.rs
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cam this file get // SAFETY comments on unsafe blocks, and /// ### Safety comments on unsafe fns?

Copy link
Copy Markdown
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanwhit nathanwhit merged commit c25f78f into main Feb 26, 2026
19 checks passed
@nathanwhit nathanwhit deleted the event-loop-rewrite-slop branch February 26, 2026 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants