Skip to content

Initial script for uploading artifacts to Azure#53

Open
tlium wants to merge 7 commits intodemisto:masterfrom
tlium:add-script-for-azure
Open

Initial script for uploading artifacts to Azure#53
tlium wants to merge 7 commits intodemisto:masterfrom
tlium:add-script-for-azure

Conversation

@tlium
Copy link
Copy Markdown

@tlium tlium commented Jan 19, 2026

@tlium tlium marked this pull request as draft January 21, 2026 08:22
@tlium
Copy link
Copy Markdown
Author

tlium commented Jan 21, 2026

Marking this PR as a draft as there are a couple of things that are not yet implemented. To keep the script more in line with the other upload scripts we need to add -b and --default_branch arguments to the script. Also, error handling needs to be improved.

@tlium tlium marked this pull request as ready for review February 16, 2026 19:57
@tlium
Copy link
Copy Markdown
Author

tlium commented Feb 16, 2026

@shmuel44 wanna take a look at this script? I think it's ready for use. Works in both mine and @pensivepaddle environments.

@shmuel44 shmuel44 assigned shmuel44 and unassigned shmuel44 Mar 18, 2026
@shmuel44 shmuel44 self-requested a review March 18, 2026 07:58
Copy link
Copy Markdown
Contributor

@shmuel44 shmuel44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tlium Thanks for the contribution!
Please see my comments.

Comment thread build_related_scripts/container_upload_azure.py
Comment thread build_related_scripts/container_upload_azure.py
Comment thread build_related_scripts/container_upload_azure.py Outdated
Comment thread build_related_scripts/container_upload_azure.py
@tlium tlium requested a review from shmuel44 March 19, 2026 13:38
@tlium
Copy link
Copy Markdown
Author

tlium commented Mar 19, 2026

Hi @shmuel44
I tried implementing the changes as per your comments. Please advise if there are other changes you would like to see, or if you disagree with the current implementation.

@tlium
Copy link
Copy Markdown
Author

tlium commented Apr 11, 2026

@shmuel44 please review

@shmuel44
Copy link
Copy Markdown
Contributor

Hi @tlium, I apologize for the late response. Have you checked if this is working after the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants