[PROTOCOL][DISCUSSION] Empty string for string type partition columns#7091
Open
dengsh12 wants to merge 1 commit into
Open
[PROTOCOL][DISCUSSION] Empty string for string type partition columns#7091dengsh12 wants to merge 1 commit into
dengsh12 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
@DrakeLin @Jameson-Crate and I found a mismatch between spark and protocol:
According the delta protocol, for string type partition columns, empty strings will be serialized as "" in json commits, and read back as null.
Spark behaves differently: serialized empty string as null. If the partition value in json commits is "", spark read back as "".
Example 1 — write
INSERT INTO t VALUES ('a', '')(partition colp = ''):partitionValuesin JSON commit{"p": ""}{"p": null}Example 2 — read commit already has
partitionValues: {"p": ""}, thenSELECT p:null''(empty string)I feel like we have several options:
nullnullOr maybe other solutions?
How was this patch tested?
Does this PR introduce any user-facing changes?