fix: allow curl fetcher to properly fallback to next mirror#15
Merged
Zeno-sole merged 1 commit intodeepin-community:masterfrom Dec 8, 2025
Merged
fix: allow curl fetcher to properly fallback to next mirror#15Zeno-sole merged 1 commit intodeepin-community:masterfrom
Zeno-sole merged 1 commit intodeepin-community:masterfrom
Conversation
Contributor
Author
|
upstream pull request ostreedev/ostree#3546 |
|
TAG Bot TAG: 2024.6-1deepin11 |
zhaohuiw42
reviewed
Dec 8, 2025
The current ostree curl fetcher has two issues that prevent proper fallback when using a mirrorlist: 1. The max_size check does not account for non-2xx responses. When a server returns 3xx, 4xx, or 5xx, the response body may exceed max_size. 2. Some state variables and temporary files are not reset when falling back to the next mirror.
zhaohuiw42
approved these changes
Dec 8, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhaohuiw42 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current ostree curl fetcher has two issues that prevent proper fallback when using a mirrorlist: