Skip to content

exchange_adaptor: Fix withdrawal amount race. #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoeGruffins merged 1 commit into from
Jul 3, 2025
Merged

exchange_adaptor: Fix withdrawal amount race. #3301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions client/mm/exchange_adaptor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,13 +164,14 @@ type pendingWithdrawal struct {
timestamp int64
withdrawalID string
assetID uint32
// amtWithdrawn is the amount the CEX balance is decreased by.
// It will not be the same as the amount received in the dex wallet.
amtWithdrawn uint64

txMtx sync.RWMutex
txID string
tx *asset.WalletTransaction
// amtWithdrawn is the amount the CEX balance is decreased by.
// It will not be the same as the amount received in the dex wallet. It
// will be updated when the transaction is confirmed.
amtWithdrawn uint64
txID string
tx *asset.WalletTransaction
}

func withdrawalBalanceEffects(tx *asset.WalletTransaction, cexDebit uint64, assetID uint32) (dex, cex *BalanceEffects) {
Expand Down Expand Up @@ -859,6 +860,9 @@ func combineBalanceEffects(dex, cex *BalanceEffects) *BalanceEffects {
// pending withdrawal and sends an event notification.
func (u *unifiedExchangeAdaptor) updateWithdrawalEvent(withdrawal *pendingWithdrawal, tx *asset.WalletTransaction) {
complete := tx != nil && tx.Confirmed
withdrawal.txMtx.RLock()
amt := withdrawal.amtWithdrawn
withdrawal.txMtx.RUnlock()
e := &MarketMakingEvent{
ID: withdrawal.eventLogID,
TimeStamp: withdrawal.timestamp,
Expand All @@ -868,7 +872,7 @@ func (u *unifiedExchangeAdaptor) updateWithdrawalEvent(withdrawal *pendingWithdr
AssetID: withdrawal.assetID,
ID: withdrawal.withdrawalID,
Transaction: tx,
CEXDebit: withdrawal.amtWithdrawn,
CEXDebit: amt,
},
}

Expand Down
Loading