Skip to content

Unminified.js #6143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mmkal wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Unminified.js #6143

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45663be
feat: generate unminified js?
mmkal Jan 21, 2022
a1020f9
fix: use a function
mmkal Jan 21, 2022
8996818
Merge branch 'master' into unminified.js
mmkal May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions scripts/webpack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
const path = require('path');
const webpack = require('webpack');
const TerserPlugin = require("terser-webpack-plugin");

@mmkal mmkal Jan 21, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to me: this should be added as an explicit dependency, it's only available because of yarn/lerna hoisting.

const FriendlyErrorsWebpackPlugin = require('friendly-errors-webpack-plugin');
const { flatMap } = require('lodash');

Expand Down Expand Up @@ -47,6 +48,9 @@ function plugins() {
ignoreEsprima: () => new webpack.IgnorePlugin(/^esprima$/, /js-yaml/),
ignoreMomentOptionalDeps: () => new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/),
friendlyErrors: () => new FriendlyErrorsWebpackPlugin(),
terser: () => new TerserPlugin({
exclude: /unminified/,
}),
};
}

Expand Down Expand Up @@ -79,12 +83,13 @@ function targetOutputs() {
return {
umd: {
path: umdPath,
filename: `${pkg.name}.js`,
filename: pathData => pathData.chunk.name === 'minified' ? `${pkg.name}.js` : `${pkg.name}.[name].js`,

@mmkal mmkal Jan 21, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erezrokah know if I need to do something similar to this for all the other target ouputs?

@erezrokah erezrokah Jan 26, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check how we're using the other targets and follow up

library: toGlobalName(pkg.name),
libraryTarget: 'umd',
libraryExport: toGlobalName(pkg.name),
umdNamedDefine: true,
globalObject: 'window',
chunkFilename: `${pkg.name}.[name].[id].[chunkhash].js`
},
umddir: {
path: umdDirPath,
Expand Down Expand Up @@ -119,7 +124,10 @@ function baseConfig({ target = isProduction ? 'umd' : 'umddir' } = {}) {
return {
context: process.cwd(),
mode: isProduction ? 'production' : 'development',
entry: './src',
entry: {
minified: './src',
unminified: './src',
},
output: targetOutputs()[target],
module: {
rules: flatMap(Object.values(rules()), rule => rule()),
Expand All @@ -131,6 +139,9 @@ function baseConfig({ target = isProduction ? 'umd' : 'umddir' } = {}) {
},
},
plugins: Object.values(plugins()).map(plugin => plugin()),
optimization: {
minimizer: [plugins().terser()],
},
devtool: isTest ? '' : 'source-map',
target: 'web',

Expand Down