Skip to content

Make Uncle Archie hooks object-oriented #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charlesreid1 wants to merge 2 commits into from
Closed

Make Uncle Archie hooks object-oriented #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9d6bac
commit the work in progress so far on converting UA to OOP
charlesreid1 Sep 11, 2018
15cfcba
Merge branch 'dcppc' of github.com:dcppc/uncle-archie into oop
charlesreid1 Sep 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions hooks/Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
# Uncle Archie Continuous Integration Hooks

This directory contains scripts that are continous integration
hooks for Uncle Archie. Each file defines a `process_payload()`
that is imported by `../process_payload.py`.
This is the `hooks/` directory, which contains all the hooks
that are run by Uncle Archie to process webhooks.

Every time a webhook is received by Uncle Archie, it calls each
function with the webhook. Each hook script must use the payload
and meta-info provided to it to determine when it should run.
Each time an incoming webhook is received, Uncle Archie creates
one and only one instance of each hook, and is agnostic to the
details of each test.

## TODO
A singleton + factory method is implemented to return one
instance of each hook. This is called by the `process_payload.py`
script (one directory up), which is called by the flask webhook
server.

These hook functions follow certain templates and borrow certain
portions of code heavily from one another. These can be integrated
into objects that define methods to simplify the rote work and
make things re-usable and easier to set up.

Loading