Skip to content

Fix Windows startup crash: permission IPC pipe path and null guard (#… #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parsakhaz merged 1 commit into from
Aug 18, 2026
+8 −6
Merged

Fix Windows startup crash: permission IPC pipe path and null guard (#… #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion main/src/services/cliManagerFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ export class CliManagerFactory {
additionalOptions?: JsonObject
) => {
let permissionIpcPath: string | null = null;
if (additionalOptions?.permissionIpcPath !== undefined) {
if (additionalOptions?.permissionIpcPath !== undefined && additionalOptions?.permissionIpcPath !== null) {
permissionIpcPath = decodeBoundary(additionalOptions.permissionIpcPath, boundary.string);
}

Expand Down
12 changes: 7 additions & 5 deletions main/src/services/permissionIpcServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,15 @@ export class PermissionIpcServer {
socketDir = os.tmpdir();
}

this.socketPath = path.join(socketDir, `pane-permissions-${process.pid}.sock`);
this.socketPath = process.platform === 'win32'
? `\\\\.\\pipe\\pane-permissions-${process.pid}`
: path.join(socketDir, `pane-permissions-${process.pid}.sock`);
}

start(): Promise<void> {
return new Promise((resolve, reject) => {
// Clean up any existing socket file
if (fs.existsSync(this.socketPath)) {
// Clean up any existing socket file (skip on Windows: named pipes are not filesystem entries)
if (process.platform !== 'win32' && fs.existsSync(this.socketPath)) {
fs.unlinkSync(this.socketPath);
}

Expand Down Expand Up @@ -116,8 +118,8 @@ export class PermissionIpcServer {

if (this.server) {
this.server.close(() => {
// Clean up socket file
if (fs.existsSync(this.socketPath)) {
// Clean up socket file (skip on Windows: named pipes are not filesystem entries)
if (process.platform !== 'win32' && fs.existsSync(this.socketPath)) {
fs.unlinkSync(this.socketPath);
}
resolve();
Expand Down