fix: use run_query in get_column_values to avoid statement name collision#1111
Open
Harish-Ranjith wants to merge 1 commit into
Open
fix: use run_query in get_column_values to avoid statement name collision#1111Harish-Ranjith wants to merge 1 commit into
Harish-Ranjith wants to merge 1 commit into
Conversation
Fixes dbt-labs#1079. When multiple models call get_column_values in the same dbt invocation, the hardcoded statement name causes MacroResultAlreadyLoadedError on the second call. Replacing with run_query() eliminates global name dependency entirely. Updated result access to use agate.Table API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1079
The macro uses a hardcoded name in statement('get_column_values') which gets stored in the global context. When two models call this macro in the same dbt run, the second call hits MacroResultAlreadyLoadedError because the name is already registered.
Switched to
un_query() which returns results directly without touching global state. Also updated result access to match the agate.Table API.
Tested locally with dbt-duckdb by calling the macro twice in one model - no error after the fix.