fix: allow Twingate step to fail without blocking chart release#276
Open
TavoDave wants to merge 1 commit into
Open
fix: allow Twingate step to fail without blocking chart release#276TavoDave wants to merge 1 commit into
TavoDave wants to merge 1 commit into
Conversation
continue-on-error: true so chart-releaser runs even if VPN is unavailable in CI Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the chart release GitHub Actions workflow to avoid failing the entire release job when the Twingate VPN connection step cannot be established in CI, unblocking helm/chart-releaser-action from publishing charts to the Helm repository.
Changes:
- Mark the “Connect to Twingate” step as non-blocking by adding
continue-on-error: truein.github/workflows/release.yml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continue-on-error: trueto the Twingate VPN step inrelease.ymlRelease Chartsworkflow was failing on every merge because Twingate cannot connect in the CI runner, blockinghelm/chart-releaser-actionfrom publishing chartscloudarmor v0.1.1was never published tohttps://dave-inc.github.io/chartsdue to this — this fix unblocks itTest plan
Release ChartsCI completes andcloudarmor v0.1.1appears in the Helm repo🤖 Generated with Claude Code