Compose simulation profiles and performance analysis - #49
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simulation profiles lived in a Python-literal registry with mutable
global state, so availability depended on import order and plugins could
not contribute profiles through Hydra. They are now config groups plus
ccflow models on the shared
ModelRegistry, matching how dau-buildalready models the same concept.
perf-svran its benchmarks directly and returned standalonedataclasses, so its parameters and results could not participate in
composition or provenance. It is now a
CallableModelwithResultBaseresults and a task entry; the CLI delegates to the composed task rather
than duplicating the logic.
Only public dependencies added (ccflow, hydra-core). The compiler IR
dataclasses are deliberately untouched — an audit confirmed those are
legitimately plain python.