Repository navigation
1.0.7; tag-driven release for both packages (trusted publishing) - #20
Merged
Merged
Conversation
…ing) - package.json 1.0.6 -> 1.0.7; pyproject.toml already reads this same version through hatch-nodejs-version, so nothing else to bump. - release.yaml: on a v* tag, checks the tag names the version, builds the wheel/sdist and the npm tarball (npm run build:lib packs everything package.json's files field lists), publishes what the registries lack through the pypi and npm environments (OIDC, no token), then a GitHub release. - RELEASE.md documents the flow and the trusted-publisher settings.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved release-workflow issues could block publishing or create a release after cancellation.
Review effort: Lite
Findings: 2
Open (4)
What changed in this PR
Adds tag-driven OIDC publishing for synchronized Python and npm packages at version 1.0.7.
Changes:
- Updates
package.jsonto version 1.0.7. - Adds automated build, validation, publishing, and GitHub release workflow.
- Documents the trusted-publishing release process.
| File | Summary |
|---|---|
RELEASE.md |
Documents the release flow. Nit: existing development documentation remains inconsistent with this process. |
package.json |
Updates the shared package version to 1.0.7. |
.github/workflows/release.yaml |
Adds release automation. Findings: critical npm authentication configuration and mutable action reference; moderate cancellation handling, incomplete sdist contents, and unlocked dependency resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| with: | ||
| name: python | ||
| path: dist | ||
| - uses: pypa/gh-action-pypi-publish@release/v1 |
Comment on lines
+126
to
+129
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '22' | ||
| registry-url: 'https://registry.npmjs.org' |
| if: steps.plan.outputs.npm != '' | ||
| run: | | ||
| set -euo pipefail | ||
| npm install --no-audit --no-fund |
| release: | ||
| name: GitHub release | ||
| needs: [build, pypi, npm] | ||
| if: always() && needs.build.result == 'success' && needs.pypi.result != 'failure' && needs.npm.result != 'failure' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


package.json1.0.6 → 1.0.7.pyproject.tomlalready reads this same version throughhatch-nodejs-version, solexical-loroand@datalayer/lexical-lorostay on one version with nothing to keep in sync by hand.release.yaml: av*tag checks that it names the version, builds the wheel, sdist and npm tarball, publishes what the registries lack through thepypiandnpmenvironments (OIDC trusted publishing, no token), then a GitHub release.RELEASE.mddocuments the flow and the trusted-publisher settings (ownerdatalayer, repositorylexical-loro, workflowrelease.yaml).Tag
v1.0.7after merge.