Skip to content

1.0.7; tag-driven release for both packages (trusted publishing) - #20

Merged
echarles merged 1 commit into
mainfrom
release/1.0.7
Sep 26, 2026
Merged

echarles merged 1 commit into
mainfrom
release/1.0.7

Conversation

@echarles

Copy link
Copy Markdown
Member
  • package.json 1.0.6 → 1.0.7. pyproject.toml already reads this same version through hatch-nodejs-version, so lexical-loro and @datalayer/lexical-loro stay on one version with nothing to keep in sync by hand.
  • release.yaml: a v* tag checks that it names the version, builds the wheel, sdist and npm tarball, publishes what the registries lack through the pypi and npm environments (OIDC trusted publishing, no token), then a GitHub release.
  • RELEASE.md documents the flow and the trusted-publisher settings (owner datalayer, repository lexical-loro, workflow release.yaml).

Tag v1.0.7 after merge.

…ing)

- package.json 1.0.6 -> 1.0.7; pyproject.toml already reads this same
  version through hatch-nodejs-version, so nothing else to bump.
- release.yaml: on a v* tag, checks the tag names the version, builds the
  wheel/sdist and the npm tarball (npm run build:lib packs everything
  package.json's files field lists), publishes what the registries lack
  through the pypi and npm environments (OIDC, no token), then a GitHub
  release.
- RELEASE.md documents the flow and the trusted-publisher settings.
Copilot AI lite review requested due to automatic review settings September 26, 2026 02:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Unresolved release-workflow issues could block publishing or create a release after cancellation.

Review effort: Lite
Findings: 2 High severity · 2 Medium severity

Open (4)
What changed in this PR

Adds tag-driven OIDC publishing for synchronized Python and npm packages at version 1.0.7.

Changes:

  • Updates package.json to version 1.0.7.
  • Adds automated build, validation, publishing, and GitHub release workflow.
  • Documents the trusted-publishing release process.
File Summary
RELEASE.md Documents the release flow. Nit: existing development documentation remains inconsistent with this process.
package.json Updates the shared package version to 1.0.7.
.github/​workflows/​release.yaml Adds release automation. Findings: critical npm authentication configuration and mutable action reference; moderate cancellation handling, incomplete sdist contents, and unlocked dependency resolution.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

with:
name: python
path: dist
- uses: pypa/gh-action-pypi-publish@release/v1
Comment on lines +126 to +129
- uses: actions/setup-node@v4
with:
node-version: '22'
registry-url: 'https://registry.npmjs.org'
if: steps.plan.outputs.npm != ''
run: |
set -euo pipefail
npm install --no-audit --no-fund
release:
name: GitHub release
needs: [build, pypi, npm]
if: always() && needs.build.result == 'success' && needs.pypi.result != 'failure' && needs.npm.result != 'failure'
@echarles
echarles merged commit 9f09dab into main Sep 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants