Eliminate VCR from siade test suite

siade/.rubocop.yml

@@ -149,10 +149,6 @@ Rails/Inquiry:
 RSpec/NestedGroups:
   Enabled: false
 
-RSpec/Output:
-  Exclude:
-    - "spec/vcr_helper.rb"
-
 RSpec/ScatteredSetup:
   Exclude:
     - "spec/requests/api/v3_and_more/**/*_spec.rb"

siade/CLAUDE.md

@@ -7,7 +7,6 @@
 - Run all tests: `bundle exec rspec`
 - Run single test: `bundle exec rspec path/to/file_spec.rb:line_number`
 - Run tests with coverage: `COVERAGE=true rspec`
-- Debug VCR cassettes or WebMock stubbing issues: `DEBUG_VCR=true rspec`
 - Generate OpenAPI docs: `bin/generate_swagger.sh`
 - Run Rubocop: `bundle exec rubocop`
 - Auto-fix Rubocop issues: `bundle exec rubocop -A`
@@ -21,7 +20,7 @@
 - Naming: Snake_case for methods/variables, CamelCase for classes
 - Error handling: Create specific error classes in app/errors/ and use the config/errors.yml configuration
 - API responses: Follow REST/JSON:API format with data/links/meta structure
-- Tests: RSpec with manually stubbed requests using WebMock. VCR is legacy - do NOT use VCR for new implementations, always use manual stubs
+- Tests: RSpec with manually stubbed requests using WebMock (see `spec/support/provider_stubs/`)
 - Model specs: Do NOT test ActiveRecord associations (belongs_to, has_many, etc.) — that's testing the framework. Only test custom behavior (scopes, methods, validations). Ensure factories are valid instead.
 - Interactors: Use organizers pattern with small, focused interactors
 - APIs: Use the scaffold_resource generator for new APIs

siade/Gemfile

@@ -71,7 +71,6 @@ group :test do
 
   gem 'json-schema'
   gem 'timecop'
-  gem 'vcr'
   gem 'webmock', '~> 3.26'
 
   gem 'ammeter'

siade/Gemfile.lock

@@ -487,7 +487,6 @@ GEM
     utf8-cleaner (2.0.1)
       activesupport
       rack (~> 3.0)
-    vcr (6.4.0)
     version_gem (1.1.14)
     webmock (3.26.3)
       addressable (>= 2.8.0)
@@ -577,7 +576,6 @@ DEPENDENCIES
   unindent
   uri (= 1.1.1)
   utf8-cleaner
-  vcr
   webmock (~> 3.26)
   xml-simple
 

siade/README.md

@@ -35,18 +35,11 @@ Avec le coverage:
 COVERAGE=true rspec
 ```
 
-Si vous rencontrez des problèmes de matching sur les cassettes VCR, vous pouvez
-obtenir plus de logs de la manière suivante:
-
-```sh
-DEBUG_VCR=true rspec
-```
-
 ### Avertissements sur les cas de tests
 
 Il n'est pas possible de mettre de données personnelles dans les tests, soit le
-fournisseur de données a un environnement de test soit il faut utiliser webmock
-et non VCR.
+fournisseur de données a un environnement de test soit il faut stubber les
+requêtes avec webmock (voir `spec/support/provider_stubs/`).
 
 ## Code Coverage
 

siade/docs/development/utilisation_et_edition_credentials.md

@@ -26,7 +26,7 @@ automatiquement selon le suffixe de la clé :
 - Toutes les autres clés → `test_<nom_cle>`
 
 Les clés nécessitant une valeur spécifique (clés RSA, chemins SSL, valeurs
-correspondant aux cassettes VCR, etc.) sont définies dans
+attendues par les stubs webmock, etc.) sont définies dans
 `spec/support/helpers/test_credentials_setup.rb`.
 
 ### Ajouter une nouvelle clé de credential

siade/spec/controllers/api_entreprise/inpi_proxy_controller_spec.rb

@@ -36,7 +36,12 @@
       its(:parsed_body) { is_expected.to have_json_api_format_errors }
     end
 
-    describe 'when RNE renders valid response', vcr: { cassette_name: 'inpi/rne/actes_download/valid' } do
+    describe 'when RNE renders valid response' do
+      before do
+        stub_inpi_rne_authenticate
+        stub_inpi_rne_download_valid(target:, document_id:)
+      end
+
       it { is_expected.to have_http_status(:ok) }
 
       it 'returns the document_url' do
@@ -57,7 +62,7 @@
         its(:parsed_body) { is_expected.to have_json_error(detail: 'Le lien de téléchargement est expiré.') }
       end
 
-      describe 'when it is a bilan', vcr: { cassette_name: 'inpi/rne/bilans_download/valid' } do
+      describe 'when it is a bilan' do
         let(:target) { 'bilans' }
 
         it { is_expected.to have_http_status(:ok) }
@@ -68,8 +73,9 @@
       end
     end
 
-    describe 'when rne renders a 404', vcr: { cassette_name: 'inpi/rne/authenticate' } do
+    describe 'when rne renders a 404' do
       before do
+        stub_inpi_rne_authenticate
         stub_inpi_rne_download_not_found(target:, document_id:)
       end
 

siade/spec/controllers/api_particulier/v2/pole_emploi/statut_controller_spec.rb

@@ -7,8 +7,10 @@
   let(:token) { TokenFactory.new(scopes).valid }
   let(:identifiant) { 'whatever' }
 
-  describe 'with valid params', vcr: { cassette_name: 'france_travail/oauth2' } do
+  describe 'with valid params' do
     before do
+      stub_france_travail_authenticate
+
       stub_request(:post, Siade.credentials[:france_travail_status_url]).and_return(
         status: 200,
         body: read_payload_file('france_travail/statut/valid.json')
@@ -56,10 +58,12 @@
     end
   end
 
-  describe 'when it is a 404', vcr: { cassette_name: 'france_travail/oauth2' } do
+  describe 'when it is a 404' do
     let(:scopes) { all_france_travail_scopes }
 
     before do
+      stub_france_travail_authenticate
+
       stub_request(:post, Siade.credentials[:france_travail_status_url]).and_return(
         status: 404,
         body: read_payload_file('france_travail/statut/not_found.json')

siade/spec/controllers/mcp_controller_spec.rb

@@ -97,6 +97,16 @@
         context 'when mcp is enabled on token' do
           let(:token) { TokenFactory.new(%w[mcp_scope1]).valid(mcp: true) }
 
+          let(:interactor_context) do
+            interactor_context = Interactor::Context.new
+            interactor_context.bundled_data = BundledData.new(data: { siren: '130025265' })
+            interactor_context
+          end
+
+          before do
+            allow(INSEE::UniteLegale).to receive(:call).and_return(interactor_context)
+          end
+
           it {
             subject
             expect(response).to have_http_status(:ok)