Skip to content

fix: Remove sticky queues properly #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gtoonstra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Remove sticky queues properly #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions charts/datafold/charts/worker-temporal/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ spec:
{{- include "worker-temporal.datafold.annotations" . | nindent 8 }}
{{- include "worker-temporal.datadog.annotations" . | nindent 8 }}
{{- if .Values.metrics.enabled }}
# Drop Temporal sticky task-queue samples at scrape time. Every workflow
# worker creates a per-pod sticky queue (task_queue="sticky.<pod>-worker-pod"),
# which explodes the cardinality of the task_queue tag. exclude_metrics_by_labels
# regex-matches the scraped label VALUE and drops the whole sample, keeping the
# real queues (io, highmem, storage, storagehigh, monitors, ...) queryable.
# NOTE: ignore_tags does NOT work here — it only filters Autodiscovery/Tagger
# tags and the `tags` option, never labels scraped from the /metrics endpoint.
ad.datadoghq.com/{{ .Chart.Name }}.checks: |
{
"openmetrics": {
Expand All @@ -37,9 +44,9 @@ spec:
},
"collect_histogram_buckets": true,
"histogram_buckets_as_distributions": true,
"ignore_tags": [
"task_queue:sticky\\..*"
]
"exclude_metrics_by_labels": {
"task_queue": ["^sticky\\."]
}
}]
}
}
Expand Down
Loading