[ENG-3846]: Add liveness probe for temporal workers#329
Open
gtoonstra wants to merge 1 commit into
Open
Conversation
🔍 Kubeconform Validation Results✅ All cloud provider configurations passed Kubernetes API schema validation!
The rendered Kubernetes manifests conform to the Kubernetes API specification across all cloud providers. |
Wires up the /livez HTTP endpoint (datafold/datafold#12364) into the worker-temporal Helm chart: exposes port 8091, sets TEMPORAL_LIVENESS_PORT, and configures a K8s livenessProbe that restarts the pod when any worker stops running, a fatal error occurs, or the process pool breaks. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
gtoonstra
force-pushed
the
gerard-eng-3846-improve-k8s-broken-pool-behavior
branch
from
9620731 to
5a50eac
Compare
🔍 Kubeconform Validation Results✅ All cloud provider configurations passed Kubernetes API schema validation!
The rendered Kubernetes manifests conform to the Kubernetes API specification across all cloud providers. |
gtoonstra
changed the title
gtoonstra
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
livenesssection toworker-temporal/values.yaml(enabled by default, port 8091, 60s initial delay, 20s period, 5s timeout, 3 failures before restart)TEMPORAL_LIVENESS_PORTenv var so the worker starts the/livezHTTP serverlivenesscontainer portlivenessProbeusinghttpGetto/livez— K8s will restart the pod when the worker reports unhealthy (worker stopped, fatal error, or broken process pool)Depends on datafold/datafold#12364.
Test plan
livenessProbeshowsSuccessin pod eventsmetricsport is unaffected when bothmetrics.enabledandliveness.enabledare true🤖 Generated with Claude Code