[DCP - Testing ] Allow our eng team to quickly connect to a DCP test bed for testing - #218
[DCP - Testing ] Allow our eng team to quickly connect to a DCP test bed for testing#218gmechali wants to merge 5 commits into
Conversation
…ly connect to test it out. Note it is IAM protected.
There was a problem hiding this comment.
Code Review
This pull request introduces a developer testbed CLI (connect.sh) and documentation to streamline deploying and testing custom container builds in GCP. The review feedback highlights several key improvements for the script, including fixing an invalid gcloud flag when creating secrets, backing up local configuration files to prevent accidental data loss, dynamically copying Terraform files, automatically generating a .gitignore for workspace directories, and avoiding nested shell execution to improve script compatibility.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces developer testbeds for the Data Commons Platform (DCP), adding a comprehensive README guide and a connect.sh helper script to manage connections, synchronize configurations with GCP Secret Manager, and handle IAM impersonation. The review feedback highlights several critical improvements for the bash script: moving the shebang to the first line to ensure it runs with Bash, wrapping the script logic in a function to prevent exit calls from terminating sourced terminal sessions, using gcloud's native filtering instead of grep to parse JSON, and adding a confirmation prompt before pushing local configurations to prevent accidental overwrites of shared secrets.
For now, we do not have any ingested data.
We can now run ./fetch_terraform_state.sh and follow prompts to get the terraform state brought in from the remote state bucket, and the terraform.tfvars from secrets.
This is deployed in datcom-dcp according to our CICD + Testing proposal.