Skip to content

[DCP - Testing ] Allow our eng team to quickly connect to a DCP test bed for testing - #218

Open
gmechali wants to merge 5 commits into
datacommonsorg:mainfrom
gmechali:testbed
Open

[DCP - Testing ] Allow our eng team to quickly connect to a DCP test bed for testing#218
gmechali wants to merge 5 commits into
datacommonsorg:mainfrom
gmechali:testbed

Conversation

@gmechali

@gmechali gmechali commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

For now, we do not have any ingested data.

We can now run ./fetch_terraform_state.sh and follow prompts to get the terraform state brought in from the remote state bucket, and the terraform.tfvars from secrets.

This is deployed in datcom-dcp according to our CICD + Testing proposal.

…ly connect to test it out. Note it is IAM protected.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a developer testbed CLI (connect.sh) and documentation to streamline deploying and testing custom container builds in GCP. The review feedback highlights several key improvements for the script, including fixing an invalid gcloud flag when creating secrets, backing up local configuration files to prevent accidental data loss, dynamically copying Terraform files, automatically generating a .gitignore for workspace directories, and avoiding nested shell execution to improve script compatibility.

Comment thread tests/testbed/connect.sh
Comment thread tests/testbed/connect.sh Outdated
Comment thread tests/testbed/connect.sh Outdated
Comment thread tests/testbed/connect.sh Outdated
Comment thread tests/testbed/connect.sh Outdated
@gmechali
gmechali requested review from clincoln8 and dwnoble August 18, 2026 22:53
@gmechali

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces developer testbeds for the Data Commons Platform (DCP), adding a comprehensive README guide and a connect.sh helper script to manage connections, synchronize configurations with GCP Secret Manager, and handle IAM impersonation. The review feedback highlights several critical improvements for the bash script: moving the shebang to the first line to ensure it runs with Bash, wrapping the script logic in a function to prevent exit calls from terminating sourced terminal sessions, using gcloud's native filtering instead of grep to parse JSON, and adding a confirmation prompt before pushing local configurations to prevent accidental overwrites of shared secrets.

Comment thread tests/testbed/connect.sh Outdated
Comment thread tests/testbed/connect.sh Outdated
Comment thread tests/testbed/connect.sh Outdated
Comment thread tests/testbed/connect.sh Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant