fix(ci): repair type-check and backend/frontend test failures on main#519
Open
will-yuponce-db wants to merge 1 commit into
Open
fix(ci): repair type-check and backend/frontend test failures on main#519will-yuponce-db wants to merge 1 commit into
will-yuponce-db wants to merge 1 commit into
Conversation
Three independent breakages were turning the Test Coverage workflow red on main (and on every PR branched from it): - TypeScript Type Check: drop unused `allPassed` local in maturity-panel, the unused Table* import in maturity-levels-settings, and the unused ReadinessChecklist import in data-product-details (TS6133/TS6192). - Backend Tests: pin the new TriggerType.ON_MATURITY_CHANGE wire value in test_trigger_enum_pin's expected table. - Frontend Tests: update system-rdf-namespace-labels test to expect the humanized fallback for unknown namespaces, matching the intentional change in dfde85d (humanize RDF source labels across UI). Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Test Coverage workflow has been failing on
main(and therefore on every PR branched from it). Three independent breakages, all introduced by recent merges, were the cause. This PR fixes all three.1. TypeScript Type Check (TS6133 / TS6192)
maturity-panel.tsx: removed unusedallPassedlocal.maturity-levels-settings.tsx: removed the fully-unusedTable*import declaration.data-product-details.tsx: removed the unusedReadinessChecklistimport.2. Backend Tests
test_trigger_enum_pin.py: the newTriggerType.ON_MATURITY_CHANGEmember (added with the maturity feature) was missing from the enum-pin table. Added("ON_MATURITY_CHANGE", "on_maturity_change").3. Frontend Tests
system-rdf-namespace-labels.test.ts: the "unknown namespace" case still asserted the raw key, but commitdfde85d2(humanize RDF source labels across UI) intentionally changed the fallback tohumanizeRdfFilename(graphKey). Updated the test to assert the humanized fallback (reusing the helper so it stays decoupled from the exact string).Verification
Run locally against the same checks CI runs:
tsc --noEmit→ clean (exit 0)vitest run src/lib/system-rdf-namespace-labels.test.ts→ 3 passedpytest src/tests/unit/test_trigger_enum_pin.py→ 34 passedThis pull request and its description were written by Isaac.