Skip to content

[native_toolchain_c] Don't require lld on PATH for MacOS -> Linux #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcharkes merged 1 commit into from
Feb 4, 2026
Merged

[native_toolchain_c] Don't require lld on PATH for MacOS -> Linux #3044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkgs/native_toolchain_c/lib/src/native_toolchain/clang.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,15 @@ final Tool lld = Tool(
wrappedResolver: clang.defaultResolver!,
relativePath: Uri.file(OS.current.executableFileName('ld')),
),
InstallLocationResolver(
toolName: 'LLD',
paths: [
'/opt/homebrew/opt/lld/bin/ld.lld',
'/opt/homebrew/bin/ld.lld',
'/usr/local/opt/lld/bin/ld.lld',
'/usr/local/bin/ld.lld',
],
),
PathToolResolver(
toolName: 'LLD',
executableName: OS.current.executableFileName('ld.lld'),
Expand Down
20 changes: 17 additions & 3 deletions pkgs/native_toolchain_c/test/cbuilder/cbuilder_cross_macos_host_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,35 @@ import 'dart:io';

import 'package:code_assets/code_assets.dart';
import 'package:hooks/hooks.dart';
import 'package:logging/logging.dart';
import 'package:native_toolchain_c/native_toolchain_c.dart';
import 'package:native_toolchain_c/src/native_toolchain/apple_clang.dart';
import 'package:native_toolchain_c/src/native_toolchain/clang.dart';
import 'package:native_toolchain_c/src/tool/tool_resolver.dart';
import 'package:native_toolchain_c/src/utils/run_process.dart';
import 'package:test/test.dart';

import '../helpers.dart';

void main() {
void main() async {
if (!Platform.isMacOS) {
// Avoid needing status files on Dart SDK CI.
return;
}

const targets = [
final context = ToolResolvingContext(logger: Logger.detached('main'));
final lldInstances = await lld.defaultResolver!.resolve(context);
final lldAvailable = lldInstances.isNotEmpty;
final lldPath = lldAvailable ? lldInstances.first.uri.toFilePath() : 'ld.lld';

if (!lldAvailable) {
stderr.writeln(
'ld.lld not found. Linux cross-compilation tests will fail.',
);
stderr.writeln("Install with 'brew install lld' on macOS.");
}

final targets = [
(OS.macOS, Architecture.arm64),
(OS.macOS, Architecture.x64),
(OS.linux, Architecture.arm),
Expand Down Expand Up @@ -135,7 +149,7 @@ void main() {
// Only homebrew lld can link for linux, and we don't have a
// sysroot so we can't use stdlibs / C-runtime files.
if (os == OS.linux) ...[
'--ld-path=ld.lld',
'--ld-path=$lldPath',
'-nostartfiles',
'-nostdlib',
],
Expand Down
Loading