Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/cronet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ jobs:
- id: install
name: Install dependencies
run: flutter pub get
- name: Build APK
run: cd example && flutter build apk && cd ..
- name: Upgrade
# Set this to `true` if you are using this workflow to regenerate the jni
# bindings.
Expand Down
1 change: 1 addition & 0 deletions pkgs/cronet_http/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## 1.10.0-wip

* Upgrade `package:jnigen` to 0.17.0.
* Add DNS configuration options to `CronetEngine.build`:
`useBuiltInDnsResolver`, `enableStaleDns`, `persistHostCache` and
`persistHostCachePeriod`. Setting `useBuiltInDnsResolver: false` forces the
Expand Down
4 changes: 4 additions & 0 deletions pkgs/cronet_http/example/android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@ org.gradle.jvmargs=-Xmx12800M
org.gradle.caching=true
android.useAndroidX=true
android.enableJetifier=true
# This builtInKotlin flag was added automatically by Flutter migrator
android.builtInKotlin=false
# This newDsl flag was added automatically by Flutter migrator
android.newDsl=false
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
4 changes: 2 additions & 2 deletions pkgs/cronet_http/example/android/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ pluginManagement {

plugins {
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
id "com.android.application" version "8.6.0" apply false
id "org.jetbrains.kotlin.android" version "2.1.0" apply false
id "com.android.application" version "8.11.1" apply false
id "org.jetbrains.kotlin.android" version "2.2.20" apply false
}

include ":app"
6 changes: 3 additions & 3 deletions pkgs/cronet_http/lib/src/cronet_client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ class CronetEngine {
try {
return using((arena) {
final builder = jb.CronetEngine$Builder(
androidApplicationContext..releasedBy(arena))
(androidApplicationContext as jb.Context)..releasedBy(arena))
..releasedBy(arena);

if (storagePath != null) {
Expand Down Expand Up @@ -802,7 +802,7 @@ class CronetClient extends BaseClient {
jUrl,
jb.UrlRequestCallbackProxy(
_urlRequestCallbacks(request, responseCompleter, profile)),
_executor,
_executor as jb.Executor,
)!
..releasedBy(arena)
..setHttpMethod(jMethod);
Expand Down Expand Up @@ -834,7 +834,7 @@ class CronetClient extends BaseClient {
}

builder.setUploadDataProvider(
jb.UploadDataProviders.create$2(data), _executor);
jb.UploadDataProviders.create$2(data), _executor as jb.Executor);
}

// Not releasing `cronetRequest` as it's used in `whenComplete` callback.
Expand Down
Loading
Loading