fix: stop the lenis scroll when autoscroll (mouse3) is pressed#527
Open
mihaicosmini wants to merge 1 commit into
Open
fix: stop the lenis scroll when autoscroll (mouse3) is pressed#527mihaicosmini wants to merge 1 commit into
mihaicosmini wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the Darkroom Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
This PR resolves a conflict between native middle-click autoscroll (activated by pressing mouse3) and Lenis smooth wheel scrolling.
What changes:
_isAutoscrollingand_middleClickTime) to track the browser's native autoscroll lifecycle.pointerupandkeydownevent listeners to thewindowto detect when autoscrolling ends.onVirtualScrollwhen_isAutoscrollingis active, ignoring virtual scroll events (e.g., mouse wheel events) while autoscrolling._isAutoscrollingstate back tofalsewhen callingreset().Why it's needed:
When a user starts autoscrolling by middle-clicking while a previous mouse wheel smooth scroll animation is still running (or scrolls the wheel during autoscroll), the native browser scroll and the Lenis scroll engine have a conflict. This causes jitter and unexpected scroll behavior. Disabling virtual scroll during autoscrolling lets the browser handle native scrolling smoothly without conflicts.
Closes #528
How to verify
bun run dev.Demo
BEFORE FIX
lenis.before.fix.2.mp4
AFTER FIX
after.lenis.fix.1.mp4
Checklist