-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
π feat: always-apply frontmatter: auto-prime skills every turn
#12746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danny-avila
merged 6 commits into
feat/agent-skills
from
feat/agent-skills-always-apply
Apr 21, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
aafc133
π refactor: Rebase always-apply work onto merged structured-frontmattβ¦
danny-avila 2562128
π§Ή fix: Dedupe manual/always-apply overlap, share YAML util, tidy commβ¦
danny-avila fe078cc
π fix: Include always-apply primes in skillPrimedIdsByName + clear alβ¦
danny-avila e8e8cb7
π§΅ refactor: Collapse duplicate prime types + tighten parse + test hygβ¦
danny-avila abaf284
π§ fix(tsc): Cast mock.calls via `unknown` for strict tuple destructure
danny-avila 06b7aed
πͺ’ fix: Propagate skillPrimedIdsByName into handoff agent tool context
danny-avila File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block now injects
alwaysApplySkillPrimes, but tool execution still buildsmanualSkillPrimedIdsByNamefrom manual primes only (viabuildManualSkillPrimedIdsByName(...)in the agent init/service path). As a result,read_filedoes not treat always-applied skills as βprimed this turnβ: always-applied skills withdisable-model-invocation: trueget blocked from reading their own files, and same-name collisions can resolve files from a different skill document than the one whose body was primed.Useful? React with πΒ / π.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in fe078cc. Valid finding β the
read_filehandler was only receiving manual primes inskillPrimedIdsByName, so always-apply skills withdisable-model-invocation: truegot blocked reading their own bundled files and same-name collisions could shadow the primed doc. RenamedbuildManualSkillPrimedIdsByNameβbuildSkillPrimedIdsByName(accepts both manual + always-apply arrays), renamed the configurable field toskillPrimedIdsByNamethroughout, and expanded the gate-relaxation doc and tests. Manual wins on the rare overlap case. Added two new tests: gate-relaxation fires for always-apply, and_idpinning works for always-apply same-name collisions.