-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
🗺️ fix: Resolve Custom-Endpoint Providers for Summarization #12739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2528093
🔧 fix: resolve custom-endpoint providers for summarization
danny-avila 60f5ad6
address: widen unresolved-env-var guard, fix test naming
danny-avila e68e7c8
address: use req.config in responses.js; forward full endpoint options
danny-avila 7bfd041
address: skip overrides when summarization matches agent endpoint
danny-avila 828126f
address: preserve raw provider when overrides cannot be built
danny-avila a39ab10
address: resolve endpoint headers and forward PROXY to summarization
danny-avila 56ab4b5
address: user summarization parameters win over endpoint defaults
danny-avila ea64dd2
address: review feedback (logging, dead code, DRY, types, deep-merge)
danny-avila fff08e1
address: review nits — import order, local test type, conflict test
danny-avila File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This passes the module-level
appConfigintocreateRun, but in this filesetAppConfighas no callers in the repository, soappConfigremainsnullon both response run paths. In that stateresolveSummarizationProvidershort-circuits and leaves custom summarization providers unresolved, so/api/agents/v1/responsesstill hitsUnsupported LLM providerfor configs likesummarization.provider: "Ollama". Passreq.confighere (as already done forsummarizationConfig) so provider resolution can actually run.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch —
setAppConfigis indeed dead code. Fixed ine68e7c8f7: bothcreateRuncalls inresponses.jsnow usereq.configdirectly (matching what the same controller already does forsummarizationConfigon line 283).