Skip to content

fix: allow empty client_secret for MCP OAuth configuration #12685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reverb256 wants to merge 1 commit into
base: main
Choose a base branch
from
+204 −176
Open

fix: allow empty client_secret for MCP OAuth configuration #12685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 12 additions & 30 deletions client/src/components/SidePanel/MCPBuilder/MCPServerDialog/sections/AuthSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { useMemo, useState } from 'react';
import { Checkbox, Input, Label, Radio, SecretInput, useToastContext } from '@librechat/client';
import { Copy, CopyCheck } from 'lucide-react';
import { useMemo, useState } from 'react';
import { useFormContext, useWatch } from 'react-hook-form';
import { Label, Input, Checkbox, SecretInput, Radio, useToastContext } from '@librechat/client';
import { AuthTypeEnum, AuthorizationTypeEnum } from '../hooks/useMCPServerForm';
import type { MCPServerFormData } from '../hooks/useMCPServerForm';
import { useLocalize, useCopyToClipboard } from '~/hooks';
import { useCopyToClipboard, useLocalize } from '~/hooks';
import { cn } from '~/utils';
import type { MCPServerFormData } from '../hooks/useMCPServerForm';
import { AuthorizationTypeEnum, AuthTypeEnum } from '../hooks/useMCPServerForm';

interface AuthSectionProps {
isEditMode: boolean;
Expand Down Expand Up @@ -183,35 +183,15 @@ export default function AuthSection({ isEditMode, serverName }: AuthSectionProps
</div>
<div className="space-y-1.5">
<Label htmlFor="oauth_client_secret" className="text-sm font-medium">
{localize('com_ui_client_secret')}{' '}
{!isEditMode && (
<>
<span aria-hidden="true" className="text-text-secondary">
*
</span>
<span className="sr-only">{localize('com_ui_field_required')}</span>
</>
)}
{localize('com_ui_client_secret')}
</Label>
<SecretInput
id="oauth_client_secret"
placeholder={isEditMode ? localize('com_ui_leave_blank_to_keep') : ''}
aria-invalid={errors.auth?.oauth_client_secret ? 'true' : 'false'}
aria-describedby={
errors.auth?.oauth_client_secret ? 'oauth-client-secret-error' : undefined
placeholder={
isEditMode ? localize('com_ui_leave_blank_to_keep') : localize('com_ui_optional')
}
{...register('auth.oauth_client_secret', { required: !isEditMode })}
className={cn(errors.auth?.oauth_client_secret && 'border-border-destructive')}
{...register('auth.oauth_client_secret')}
/>
{errors.auth?.oauth_client_secret && (
<p
id="oauth-client-secret-error"
role="alert"
className="text-xs text-text-destructive"
>
{localize('com_ui_field_required')}
</p>
)}
</div>
</div>

Expand Down Expand Up @@ -265,7 +245,9 @@ export default function AuthSection({ isEditMode, serverName }: AuthSectionProps
type="button"
onClick={() => {
if (isCopying) return;
showToast({ message: localize('com_ui_copied_to_clipboard') });
showToast({
message: localize('com_ui_copied_to_clipboard'),
});
copyLink(setIsCopying);
}}
className="flex size-10 shrink-0 items-center justify-center rounded-lg border border-border-light text-text-secondary transition-colors hover:bg-surface-hover hover:text-text-primary"
Expand Down
Loading