💰 fix: Load app config in set-balance script to respect balance settings#12669
Open
ucodia wants to merge 1 commit intodanny-avila:mainfrom
Open
💰 fix: Load app config in set-balance script to respect balance settings#12669ucodia wants to merge 1 commit intodanny-avila:mainfrom
set-balance script to respect balance settings#12669ucodia wants to merge 1 commit intodanny-avila:mainfrom
Conversation
…tings The `set-balance` script called `getBalanceConfig()` without the app config, so it always reported balance as disabled regardless of the librechat.yaml configuration. Mirror the working `add-balance` script by loading the app config first and passing it into `getBalanceConfig`. Fixes danny-avila#12413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
npm run set-balancecommand always errored withError: Balance is not enabled. Use librechat.yaml to enable iteven when balance was correctly configured inlibrechat.yaml.Root cause:
config/set-balance.jscalledgetBalanceConfig()without the app config argument, so it couldn't read balance settings. The siblingconfig/add-balance.jsscript already does this correctly by loading the app config first and passing it in.This PR aligns
set-balance.jswithadd-balance.js:getAppConfigfrom~/server/services/ConfiggetAppConfig()before checking balance configappConfigintogetBalanceConfig(appConfig)Fixes #12413 and #12412
Change Type
Testing
Verified against a locally built Docker image:
librechat.yaml:npm run set-balance <email> <amount>inside the container.Error: Balance is not enabled. Use librechat.yaml to enable it.Balance.findOneAndUpdate, and printsBalance set successfully!along with the new balance.npm run add-balance, which was already working correctly with the same config loading pattern.Test Configuration:
librechat.yamlwithbalance.enabled: trueChecklist