feat: add support for tsconfig.json files that have an extends property#1361
Closed
luchn49 wants to merge 8 commits intodanger:mainfrom
Closed
feat: add support for tsconfig.json files that have an extends property#1361luchn49 wants to merge 8 commits intodanger:mainfrom
luchn49 wants to merge 8 commits intodanger:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up the PR #1313
Description copied from #1313:
What does the PR do?
Fixes issue #1283.
Following what was suggested in the issue to mimic what ts-node is doing to resolve the tsconfig.json here.
Their method is quite a bit more complex since they need to resolve custom ts-node compiler options.
For our purposes, reading the config file using ts.readConfigFile and then parsing it with ts.parseJsonConfigFileContent produces the expected tsconfig.json even when it extends another one.
Tests
Added a test to confirm that danger resolves extended tsconfigs.