Fix release workflow for MTP test runner and container tagging - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow has two issues after the xunit v3 / MTP migration merged in PR #10:
Test step fails —
dotnet testagainst the solution discovers the Aspire test DLL which has zero tests in CI, causing MTP exit code 8. Fixed by targeting onlyMicroStack.Tests.csprojwith--projectand excludingContainerSmokeTestsvia--filter-not-class.Container image not tagged with release version — The publish step relied on MinVer for tagging but didn't pass explicit tags. Now passes
ContainerImageTagswith the workflow's version input +latest.Reviewer focus
--projectand--filter-not-classflags match the CI workflowContainerImageTagsquoting works correctly in the YAML blockRisk / impact