[!] add Prometheus exporter as a pgwatch source - #1405
Merged
Conversation
pashagolub
added
epic
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Coverage Report for CI Build 31096149792Coverage decreased (-1.0%) to 85.321%Details
Uncovered Changes
Coverage Regressions18 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
Collaborator
|
Won't this be an unnecessary additional complexity, users can just use pgwatch as a prometheus exporter - which is a logical thing to do to avoid unnecessarily managing additional solution[s] - ?. |
Collaborator
Author
I believe you miss the whole point of this feature. This is to fetch measurements from Prometheus, e.g. patroni |
pashagolub
commented
May 14, 2026
pashagolub
force-pushed
the
prom-sources
branch
from
August 5, 2026 17:30
392a91c to
1b06036
Compare
pashagolub
marked this pull request as ready for review
August 5, 2026 17:31
pashagolub
changed the title
- Add `SourceConn` interface with `Connect()`, `Ping(), `IsPostgresSource()`, `GetSource()`, `GetMetricInterval()`, `SetMetricIntervals()`, and `Close()` methods - Rename `SourceConn` struct to `DbConn`; keep `NewSourceConn()` as a factory returning the interface, add `NewDbConn()` as the constructor - Add `PromConn` stub struct implementing `SourceConn` for Prome sources - Change `SourceConns` from []*SourceConn to interface slice - Add `SourceRunner` interface in reaper package for worker abstraction - Update `reaper.Reap()` to dispatch via type switch - Update all callsites across reaper, sources, and cmdopts packages
Extend `WritePromMetrics()` and `AddCacheEntry()` to handle envelopes whose SourceKind is 'prometheus' (the prom→prom proxy path):
`HEAD` request is not supported by patroni and might be ignored by others
Master's integration test (renamed in 0a2a980) uses `metricName`. The PR introduced `batchEntry` with field `name`; align with master.
pashagolub
force-pushed
the
prom-sources
branch
from
August 6, 2026 11:09
f7f5eee to
4882b36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow pgwatch to scrape arbitrary Prometheus exporters, apply family-level filtering, and write measurements to any configured sink — including acting as a low-overhead proxy when the sink is a Prometheus endpoint.