Evaluate map expression and pattern matching#185
Open
neoaggelos wants to merge 3 commits into
Open
Conversation
This commit introduces support for evaluating map expressions and matching patterns containing maps. It also adds initial support for the maps:get() and maps:put() standard library functions.
kostis
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
References #183. Support expressions and pattern matching for Erlang maps.
This PR can be reviewed and merged separately from #184, but any future work on maps greatly depends on these two PRs getting merged.
Changes
mapandmap_pairnodes. This is required for pattern matching to work properly.{c_map, ...}(maps) and{c_map_pair, ...}(key-value pairs) nodes ineval_expr/6.{c_map, ...}(maps) and{c_map_pair, ...}(key-value pairs) nodes inpattern_match/9mapsstandard library (maps:get,maps:putandis_map).Testing
Notes
maps:getandmaps:putfrom the standard library as well. The rest of the standard library (e.g.maps:from_list,maps:to_list) is not straightforward to support and will be added in a separate PR.--disable-pmatchis required, since map values are not handled.