Skip to content

Update function-patch-and-transform version to 0.8.2#890

Merged
jbw976 merged 1 commit intocrossplane:masterfrom
mattwelke:docs/correct-function-version-in-quickstarts-mar10
Mar 14, 2025
Merged

Update function-patch-and-transform version to 0.8.2#890
jbw976 merged 1 commit intocrossplane:masterfrom
mattwelke:docs/correct-function-version-in-quickstarts-mar10

Conversation

@mattwelke
Copy link
Copy Markdown
Contributor

@mattwelke mattwelke commented Mar 10, 2025

Updates the master folder of the docs to use the latest version of the transform and patch function so that a user following the quickstart will be successful.

There are some whitespace changes that made their way into this PR too. I'm not sure why. I tried to exclude them, but the files are changed when I run git add. I checked for Git hooks and the like, but didn't see any. Let me know if this is an issue.

Background:

I found when completing the GCP quickstart that during part 2, it fails when you get to the step where you apply a Function. The function never reaches the installed state because it cannot fetch the package:

cannot unpack package: failed to fetch package digest from remote: failed to fetch package descriptor with a GET request after a previous HEAD request failure: HEAD https://xpkg.crossplane.io/v2/crossplane-contrib/function-patch-and-transform/manifests/v0.1.4: unexpected status code 404 Not Found (HEAD responses have no body, use GET for details): GET https://xpkg.crossplane.io/v2/crossplane-contrib/function-patch-and-transform/manifests/v0.1.4: MANIFEST_UNKNOWN: manifest unknown

I resolved this issue by finding out what the latest version of the function package was (v0.8.2) and trying that instead. It worked, and I was able to complete the quickstart.

Note that there is another known issue with the quickstart in the master folder of the docs that I had to work around too (in this case, I did so by adding the cluster-admin role to the Pub/Sub provider pod's service account).

Signed-off-by: Matt Welke <mattwelke@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 10, 2025

Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit bfd0fe9
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/67cf41e8d117a000087de44a
😎 Deploy Preview https://deploy-preview-890--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🟢 up 12 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very helpful @mattwelke, thank you for taking care of this!! could you also make these same changes to the content/v1.19 folder too? that's the latest docs version and the default that everyone sees, so it will be good to have the changes there so folks see it by default 😇

@jbw976
Copy link
Copy Markdown
Member

jbw976 commented Mar 14, 2025

it is indeed that you're getting these whitespaces changes on git add - i get them on save in my editor because i have format on save or something like that enabled, but git add I can not explain for you 😂

Copy link
Copy Markdown
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let's go ahead and merge this as is @mattwelke - i'm doing a big pass through all the docs for crossplane/crossplane#6320 / #888, so I'll hit all these as I'm going through that. If we both do some work we'll likely just run into conflicts together 😂

@jbw976 jbw976 merged commit 94039ba into crossplane:master Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants