Skip to content

Fix typo on Helm Upgrade command with arguments#886

Merged
jbw976 merged 4 commits intocrossplane:masterfrom
Xtema:fix/fix-helm-upgrade-doc
Mar 4, 2025
Merged

Fix typo on Helm Upgrade command with arguments#886
jbw976 merged 4 commits intocrossplane:masterfrom
Xtema:fix/fix-helm-upgrade-doc

Conversation

@Xtema
Copy link
Copy Markdown

@Xtema Xtema commented Mar 4, 2025

Description of your changes

Fix typo on Helm Upgrade command with arguments
Fixes #6267

I have:

  • Read and followed Crossplane's [contribution process(https://github.com/crossplane/crossplane/tree/main/contributing).
  • Run earthly +reviewable to ensure this PR is ready for review.
  • [] Added or updated unit tests.
  • [] Added or updated e2e tests.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 4, 2025 •
edited
Loading

✅ Deploy Preview for crossplane ready!

Name Link
🔨 Latest commit 067d9da
🔍 Latest deploy log https://app.netlify.com/sites/crossplane/deploys/67c71e8c3b8b030008757f55
😎 Deploy Preview https://deploy-preview-886--crossplane.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 86 (🟢 up 5 from production)
Accessibility: 90 (🔴 down 2 from production)
Best Practices: 83 (no change from production)
SEO: 100 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Xtema Xtema mentioned this pull request Mar 4, 2025
Closed
jbw976
jbw976 reviewed Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR @Xtema!! can you also fix in v1.17 and v1.19?

@jbw976
Copy link
Copy Markdown
Member

jbw976 commented Mar 4, 2025 •
edited
Loading

Also, the DCO check is failing, even though you did include a sign-off. it looks like the sign-off doesn't match what github expects 🤔 - can you amend that? https://github.com/crossplane/crossplane/blob/main/contributing/README.md#certificate-of-origin will be helpful here .

Commit sha: c40d0b8, Author: Bruno Costa, Committer: Bruno Costa; Expected "Bruno Costa redacted@....co.uk", but got "Bruno Costa redacted@hotmail.com".

@Xtema
Copy link
Copy Markdown
Author

Xtema commented Mar 4, 2025 •
edited
Loading

@jbw976 Glad I can help.

Added the fix for version 1.17, 1.18 and 1.19 too.

I had the email amended; it should match now.
Thanks.

@Xtema Xtema force-pushed the fix/fix-helm-upgrade-doc branch from 969108f to 79d58c7 Compare March 4, 2025 15:35
Bruno Costa added 4 commits March 4, 2025 15:38
@Xtema
Fix typo on Helm Upgrade command with arguments
5a53fe9 
Signed-off-by: Bruno Costa <ninguex@hotmail.com>
Signed-off-by: Bruno Costa <bruno.costa@marionete.co.uk>
Signed-off-by: Bruno Costa <ninguex@hotmail.com>
@Xtema
Fix typo for version 1.17 and 1.18
c0a90f4 
Signed-off-by: Bruno Costa <bruno.costa@marionete.co.uk>
Signed-off-by: Bruno Costa <ninguex@hotmail.com>
@Xtema
Fix typo for version 1.19
b2753fd 
Signed-off-by: Bruno Costa <bruno.costa@marionete.co.uk>
Signed-off-by: Bruno Costa <ninguex@hotmail.com>
@Xtema
Fix typo for version 1.18
067d9da 
Signed-off-by: Bruno Costa <bruno.costa@marionete.co.uk>
Signed-off-by: Bruno Costa <ninguex@hotmail.com>
@Xtema Xtema force-pushed the fix/fix-helm-upgrade-doc branch from 79d58c7 to 067d9da Compare March 4, 2025 15:38
jbw976
jbw976 approved these changes Mar 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jbw976 jbw976 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, this looks good to me for all versions on the preview site now too! Thanks again @Xtema! 🙇‍♂️

@jbw976 jbw976 merged commit 31e10ec into crossplane:master Mar 4, 2025
@Xtema Xtema deleted the fix/fix-helm-upgrade-doc branch March 4, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbw976 jbw976 jbw976 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Web Bug] - Upgrade Crossplane

2 participants

@Xtema @jbw976