[wip] Cumulative micro opts (1-2% perf. gain)#1092
Conversation
I appreciate the contribution, but a patch that mixes various different-purpose changes without any particular explanation of each change is also the kind of patch that takes time to review... As for the changes:
If this PR's purpose is to help merge your other PRs, I honestly think it would be better to add tests to complete them. It is not easy to review PRs that add new APIs but have no tests (and there is no possibility of such PRs being merged as is). |
|
(thanks for various feedback; I'll appreciate very much; I'll reply to these later. focusing on #1040 for now) |
|
I will close this PR as it will never be merged in the current format that includes such a lot of subtle changes. Thanks anyway for the PR! |
Well, I REALLY want my other prs to be merged (or decided to be rejected, so that i can decide to fork crossbeam for my work....). All of them got stale for long time for some reason.
So, I'm wondering whether it could help by actively contributing to crossbeam or not, in order to indicate my willingness to spend my time in exchange of my prs got being reviewed. :)
here it is. Assorted of micro ops, i came up with. note that I haven't evaluated each in depth. This pr is to start triage them from more knowledgeable people. so that I can create more serious prs for each.
General theme of them is to reduce instructions.
(note to self):