Revert "Fix PMS stop registering playback state after 6-10 music tracks" - #2236
Open
camhorn wants to merge 1 commit into
Open
Revert "Fix PMS stop registering playback state after 6-10 music tracks"#2236camhorn wants to merge 1 commit into
camhorn wants to merge 1 commit into
Conversation
|
This didn't seem to fix the issue for m :( |
Author
|
@mason1171 Can you be more specific? Note that this was meant to repair the prior behavior of advancing to the next episode, not to address the purported issue of the breaking change ("Fix PMS stop registering..."). I don't believe either the fix nor this reversion address that issue. |
|
Oh, i was under the impression this was to fix playback sessions triggered with Up Next not reported on the PMS side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2224
This logic is incorrect, leading to the observed behavior plex believing the previous episode is still playing when advancing to the next via Up Next. See #2224 (comment)
There may be additional edge cases, but the prior logic was more correct. It certainly doesn't make sense to expect the same index to have comparable meaning over two different mutable lists.