PermTarget::Value is Sized. This avoids a lot of dereferencings in many places.#2089
Merged
PermTarget::Value is Sized. This avoids a lot of dereferencings in many places.#2089
Conversation
…ny places. The only "downside" is that we can no longer implement View for Perm, but anyway ViewTy was a shared borrow, which was not what we wanted.
jhjourdan
force-pushed
the
permtarget_val_sized
branch
from
8160cb2 to
33ac1e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only "downside" is that we can no longer implement View for Perm, but anyway ViewTy was a shared borrow, which was not what we wanted.