Operations on AtomicI32#1844
Merged
Lysxia merged 2 commits intocreusot-rs:masterfrom Jan 9, 2026
Merged
Conversation
jhjourdan
reviewed
Dec 2, 2025
Collaborator
jhjourdan
left a comment
jhjourdan
left a comment
There was a problem hiding this comment.
Plenty of other atomic types and operations are missing, we should use a macro to generate specs for all of them.
Also, missing : at least one test.
Naming: what about renamig LocalInvariant -> ThreadInvariant (or something else like NonAtomicInvariant : I simply don't like LocalInvariant).
While I understand why you used a wrapper around AtomicI32 (and I somehow agree), I disagree with the idea of moving them to ghost::atomic_invariant. This has nothing to do with invariants, really. So we should either add a dedicated module or move this to std::sync::atomic (even though this is arguable because this is really a different type).
dianegolfouse
force-pushed
the
atomics
branch
2 times, most recently
from
90b37cb to
fd95951
Compare
lafeychine
force-pushed
the
atomics
branch
2 times, most recently
from
a9f04ca to
ed83f1c
Compare
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
reviewed
Dec 18, 2025
jhjourdan
force-pushed
the
atomics
branch
5 times, most recently
from
98dc112 to
e37c3aa
Compare
Collaborator
|
If you agree, I think the current situation is acceptable. |
lafeychine
force-pushed
the
atomics
branch
6 times, most recently
from
78fa642 to
7ac65f6
Compare
Lysxia
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.