Repository navigation
Let setup-pstack seat any model T3's catalog search finds - #704
Merged
Merged
Conversation
Applies the review's edits from reports/D59-review-1.md at b43aa75.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On T3 Code 0.1.4,
orchestrator_capabilitiesreturns a short list. Outside Codex, Claude, Muse, and Grok it lists at most eight models per provider and counts the rest inomittedModels, and an optionalsearchstring finds them. setup-pstack treated the short list as the whole catalog, soroles.py writerefused a real model the list left out, and a note naming a configured model the list omitted read as if T3 had dropped it.roles.py catalog merge --catalog <file> --from <file|->merges one search result into the saved catalog. Models merge by provider and model id. A model the saved file already has keeps its saved entry and options. A provider that brings no models is skipped. A result that brings a model for a provider the saved catalog lacks or cannot run, or that brings no model at all, exits 2 and writes nothing. A merge that adds nothing writes nothing, so a repeated merge is byte-identical.roles.py showadds asearchlist to a role entry when a configured seat's provider is runnable, omits models, and lacks that seat's model.searchentry to get the model id, and treat an empty search as no proof the model is unavailable.orchestrator_capabilitiestakes nosearchkeeps using the saved catalog as before, andshowprints nosearchlist on a catalog withoutomittedModels.Measured on this host: one unfiltered call listed 33 of 157 models across the runnable providers, and the OpenCode provider listed 9 of 71. The counts move as provider catalogs refresh. After a search and merge,
writeacceptedopencode-go/kimi-k3.1-pro, which it refused before.Proved by: eight new tests in
tests/pstack_t3/test_catalog_merge.py, each caught alone by its own mutation in review; the roles suite (344 tests); the full suite at the worker's head and again after the review edits, on Python 3 and 3.12;scripts/build.pyandscripts/check.pyclean; and the reviewer's live run of search, merge, write, and snapshot against the real T3 catalog.Coordinated by claudeAgent/claude-opus-5-5. Written by opencode-go/deepseek-v4.1-flash and opencode-go/muse-spark-1.3-contributor. Reviewed by codex/gpt-6.1-sol.