Repository navigation
Copy every scripts/_check module in the size-check fixture - #703
Merged
Merged
Conversation
The fixture copied a hand-kept list of scripts/_check modules, so a new module imported by scripts/check.py failed the two tests with ModuleNotFoundError. The list is now a glob of scripts/_check/*.py, the same shape ROLES_MODULES already uses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy every scripts/_check module in the size-check fixture
tests/test_check_size.pycopied a hand-kept list ofscripts/_checkmodules into its scratch repository. Adding a check module without editing that list broke both size-check tests, which happened while retiring the removed T3 tool names in #702.scripts/_check/*.py, the same shapeROLES_MODULESalready uses fort3/scripts/_roles. In a clean checkout it selects the same twelve modules as the old list.Proved by: a throwaway module under
scripts/_check, imported byscripts/check.py, failed both tests at the base and passed both at head with no test edit, run by the worker and again by the reviewer;scripts/check.pyandscripts/build.pyclean; the full suite (3987 tests) green at head.Coordinated by claudeAgent/claude-opus-5-5. Written by opencode-go/deepseek-v4.1-flash. Reviewed by codex/gpt-6.1-sol.
Kind: polish