Feat/login url handling and errors#52
Merged
Merged
Conversation
Ldoppea
force-pushed
the
feat/login_url_handling_and_errors
branch
2 times, most recently
from
f06e432 to
60520fc
Compare
Crash--
reviewed
Nov 30, 2021
Crash--
reviewed
Nov 30, 2021
Crash--
reviewed
Nov 30, 2021
Crash--
approved these changes
Nov 30, 2021
Contributor
Crash--
left a comment
Crash--
left a comment
There was a problem hiding this comment.
except translation strings, 👍
Sanitize Cozy url before login Display a user friendly exception in case of badly formated Cozy url
CozyStack error messages do not fit Bitwarden's errors format so we have to create a custom parser for them
As the stack does not translate error messages and 401 is the most common error then we intercept this specific error to translate it on client side
Ldoppea
force-pushed
the
feat/login_url_handling_and_errors
branch
from
60520fc to
9ffea65
Compare
delete-merged-branch
Bot
deleted the
feat/login_url_handling_and_errors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: