-
Notifications
You must be signed in to change notification settings - Fork 172
fix: fix widget retry logic #7636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Danziger
wants to merge
5
commits into
develop
Choose a base branch
from
feat/fix-widget-retry-logic
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+194
−59
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2476c83
fix: fix widget retry logic
Danziger debf435
Merge branch 'develop' into feat/fix-widget-retry-logic
Danziger 18a7631
Merge branch 'develop' into feat/fix-widget-retry-logic
Danziger 167870f
Merge branch 'develop' into feat/fix-widget-retry-logic
Danziger 158a172
Merge branch 'develop' into feat/fix-widget-retry-logic
fairlighteth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,152 +1,287 @@ | ||
| import { WIDGET_IFRAME_ALLOW, WIDGET_IFRAME_REFERRER_POLICY, WIDGET_IFRAME_SANDBOX } from './cowSwapWidget.constants' | ||
| import { WidgetMethodsEmit } from './types' | ||
| import { widgetIframeTransport } from './widgetIframeTransport' | ||
|
|
||
| const IFRAME_LOADING_TIMEOUT = 30_000 // 30 sec | ||
| /** After the probe iframe document loads, wait this long for READY before treating the probe as failed. */ | ||
| const PROBE_READY_WAIT_TIMEOUT = 10_000 // 10 sec | ||
| const WIDGET_TRANSPORT_KEY = 'cowSwapWidget' | ||
| const WIDGET_LOAD_RETRY = 'WIDGET_LOAD_RETRY' | ||
|
|
||
| const RELOAD_BUTTON_CLASS = 'coWWidgetContentReloadButton' | ||
| const RELOAD_BUTTON_CLASS = 'reloadButton' | ||
| const RETRY_BUTTON_LABEL = 'Retry' | ||
| const RETRY_BUTTON_LOADING_LABEL = 'Loading...' | ||
|
|
||
| type IframeLoadingState = { cancelWidgetLoading: () => void; onWidgetReady: () => void } | ||
| type WindowListener = (event: MessageEvent) => void | ||
|
|
||
| function isWidgetLoadRetryMessage(data: unknown): boolean { | ||
| return ( | ||
| typeof data === 'object' && | ||
| data !== null && | ||
| 'key' in data && | ||
| data.key === WIDGET_TRANSPORT_KEY && | ||
| 'method' in data && | ||
| data.method === WIDGET_LOAD_RETRY | ||
| ) | ||
| } | ||
|
|
||
| // eslint-disable-next-line max-lines-per-function | ||
| export function widgetIframeLoading( | ||
| iframe: HTMLIFrameElement, | ||
| onWidgetLoadingError?: () => void, | ||
| customErrorStyles?: string, | ||
| ): IframeLoadingState { | ||
| const originalSrc = iframe.src | ||
| const widgetOrigin = new URL(originalSrc).origin | ||
|
|
||
| let cancelled = false | ||
| let isLoaded = false | ||
| let loadingTimeout: ReturnType<typeof setTimeout> | undefined | ||
| let loadingTimeoutID = 0 | ||
| let tempIframe: HTMLIFrameElement | null = null | ||
| let checkIfCowSwapLoadsTimeoutID = 0 | ||
| let activeProbeReadyListener: WindowListener | null = null | ||
| let isCheckingIfCowSwapLoads = false | ||
|
|
||
| function cleanUpLoadCheck(isChecking = false): void { | ||
| clearTimeout(checkIfCowSwapLoadsTimeoutID) | ||
| isCheckingIfCowSwapLoads = isChecking | ||
|
|
||
| function onIframeLoadingError(): void { | ||
| iframe.srcdoc = ERROR_DOCUMENT | ||
| onWidgetLoadingError?.() | ||
| if (activeProbeReadyListener) { | ||
| window.removeEventListener('message', activeProbeReadyListener) | ||
| activeProbeReadyListener = null | ||
| } | ||
|
|
||
| if (tempIframe) { | ||
| tempIframe.remove() | ||
| tempIframe = null | ||
| } | ||
| } | ||
|
|
||
| function startLoadingTimeout(): void { | ||
| clearTimeout(loadingTimeout) | ||
| function showErrorDocument(emitEvent = false): void { | ||
| if (cancelled || isLoaded) return | ||
|
|
||
| loadingTimeout = setTimeout(() => { | ||
| if (cancelled || isLoaded) return | ||
| clearTimeout(loadingTimeoutID) | ||
|
|
||
| onIframeLoadingError() | ||
| }, IFRAME_LOADING_TIMEOUT) | ||
| iframe.srcdoc = buildErrorDocument(customErrorStyles) | ||
|
|
||
| if (emitEvent && onWidgetLoadingError) onWidgetLoadingError() | ||
| } | ||
|
|
||
| function retryWidgetLoading(): void { | ||
| function startLoadingTimeout(): void { | ||
| clearTimeout(loadingTimeoutID) | ||
|
|
||
| loadingTimeoutID = window.setTimeout(() => showErrorDocument(true), IFRAME_LOADING_TIMEOUT) | ||
| } | ||
|
|
||
| function completeCleanUpLoadCheck(succeeded: boolean): void { | ||
| if (!isCheckingIfCowSwapLoads) return | ||
|
|
||
| cleanUpLoadCheck() | ||
|
|
||
| if (cancelled || isLoaded) return | ||
|
|
||
| // `srcdoc` takes precedence over `src`, so it must be removed to load the widget again | ||
| iframe.removeAttribute('srcdoc') | ||
| iframe.src = originalSrc | ||
| if (succeeded) { | ||
| // `srcdoc` takes precedence over `src`, so it must be removed to load the widget again | ||
| iframe.removeAttribute('srcdoc') | ||
| iframe.src = originalSrc | ||
| startLoadingTimeout() | ||
| return | ||
| } | ||
|
|
||
| startLoadingTimeout() | ||
| // Reset the error document | ||
| showErrorDocument(!iframe.hasAttribute('srcdoc')) | ||
| } | ||
|
|
||
| /** | ||
| * Once the error document is loaded, attaches the retry handler and integrator styles. | ||
| * The widget itself is cross-origin, so `contentDocument` is null and this is a no-op for it. | ||
| */ | ||
| function onIframeLoad(): void { | ||
| if (cancelled) return | ||
|
|
||
| const errorDocument = iframe.contentDocument | ||
| const reloadButton = errorDocument?.querySelector(`.${RELOAD_BUTTON_CLASS}`) | ||
| function checkIfCowSwapLoads(): void { | ||
| if (cancelled || isLoaded || isCheckingIfCowSwapLoads) return | ||
|
|
||
| if (!errorDocument || !reloadButton) return | ||
| cleanUpLoadCheck(true) | ||
|
|
||
| reloadButton.addEventListener('click', retryWidgetLoading) | ||
| tempIframe = document.createElement('iframe') | ||
| tempIframe.setAttribute('sandbox', iframe.getAttribute('sandbox') ?? WIDGET_IFRAME_SANDBOX) | ||
| tempIframe.referrerPolicy = iframe.referrerPolicy || WIDGET_IFRAME_REFERRER_POLICY | ||
| tempIframe.allow = iframe.allow || WIDGET_IFRAME_ALLOW | ||
| tempIframe.style.cssText = 'position:absolute;width:0;height:0;border:0;visibility:hidden' | ||
| document.body.appendChild(tempIframe) | ||
|
|
||
| if (customErrorStyles) { | ||
| const customStylesEl = errorDocument.createElement('style') | ||
| const iframeContentWindow = tempIframe.contentWindow | ||
|
|
||
| // textContent is not parsed as HTML, so the styles cannot break out of the <style> element | ||
| customStylesEl.textContent = customErrorStyles | ||
| errorDocument.head.appendChild(customStylesEl) | ||
| if (!iframeContentWindow) { | ||
| completeCleanUpLoadCheck(false) | ||
| return | ||
| } | ||
|
|
||
| tempIframe.addEventListener('error', () => { | ||
| completeCleanUpLoadCheck(false) | ||
| }) | ||
|
|
||
| tempIframe.addEventListener('load', () => { | ||
| // Browsers might just fire `load` event instead of `error`, so we wait briefly for READY: | ||
| clearTimeout(checkIfCowSwapLoadsTimeoutID) | ||
| checkIfCowSwapLoadsTimeoutID = window.setTimeout(() => { | ||
| completeCleanUpLoadCheck(false) | ||
| }, PROBE_READY_WAIT_TIMEOUT) | ||
| }) | ||
|
|
||
| tempIframe.src = originalSrc | ||
|
|
||
| activeProbeReadyListener = widgetIframeTransport.listenToMessageFromWindow( | ||
| window, | ||
| iframeContentWindow, | ||
| WidgetMethodsEmit.READY, | ||
| () => completeCleanUpLoadCheck(true), | ||
| widgetOrigin, | ||
| ) | ||
|
|
||
| // Fallback when the probe navigation never fires `load` (rare). | ||
| checkIfCowSwapLoadsTimeoutID = window.setTimeout(() => { | ||
| completeCleanUpLoadCheck(false) | ||
| }, IFRAME_LOADING_TIMEOUT) | ||
| } | ||
|
|
||
| function onRetryMessage(event: MessageEvent): void { | ||
| if (cancelled || isLoaded || isCheckingIfCowSwapLoads) return | ||
| if (event.source !== iframe.contentWindow) return | ||
| if (!isWidgetLoadRetryMessage(event.data)) return | ||
|
|
||
| checkIfCowSwapLoads() | ||
| } | ||
|
|
||
| iframe.addEventListener('error', (iframeLoadingError) => { | ||
| if (cancelled) return | ||
|
|
||
| console.error('Could not load iframe', iframeLoadingError) | ||
|
|
||
| onIframeLoadingError() | ||
| showErrorDocument(true) | ||
| }) | ||
|
|
||
| iframe.addEventListener('load', onIframeLoad) | ||
| window.addEventListener('message', onRetryMessage) | ||
|
|
||
| startLoadingTimeout() | ||
|
|
||
| return { | ||
| cancelWidgetLoading() { | ||
| cancelled = true | ||
| clearTimeout(loadingTimeout) | ||
| iframe.removeEventListener('load', onIframeLoad) | ||
| clearTimeout(loadingTimeoutID) | ||
| cleanUpLoadCheck() | ||
| window.removeEventListener('message', onRetryMessage) | ||
| }, | ||
| onWidgetReady() { | ||
| isLoaded = true | ||
| clearTimeout(loadingTimeout) | ||
| clearTimeout(loadingTimeoutID) | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * A static HTML document displayed inside the iframe (via `srcdoc`) when the widget fails to load. | ||
| * Escapes `<` so integrator CSS cannot break out of the inline `<style>` element. | ||
| */ | ||
| function sanitizeInlineStyle(css: string): string { | ||
| return css.replace(/</g, '\\3C ') | ||
| } | ||
|
|
||
| /** | ||
| * HTML document displayed inside the iframe (via `srcdoc`) when the widget fails to load. | ||
| * Rendering the error inside the iframe keeps the DOM structure and iframe attributes/styles | ||
| * set by the integrator intact. | ||
| * | ||
| * The document is intentionally static (no interpolation) to rule out HTML injection. | ||
| * Since the iframe sandbox includes `allow-same-origin` and `srcdoc` documents inherit the parent | ||
| * origin, the parent script wires the retry button and custom styles directly via DOM access. | ||
| * Retry and loading UI are handled by an inline script inside the error document, because the | ||
| * parent cannot reliably access the iframe DOM at load time in every browser. | ||
| */ | ||
| const ERROR_DOCUMENT = `<!DOCTYPE html> | ||
| // eslint-disable-next-line max-lines-per-function | ||
| function buildErrorDocument(customErrorStyles?: string): string { | ||
| const integratorStyles = customErrorStyles ? `<style>${sanitizeInlineStyle(customErrorStyles)}</style>` : '' | ||
|
|
||
| return `<!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <style> | ||
| html, body { margin: 0; padding: 0; width: 100%; height: 100%; } | ||
|
|
||
| p { margin: 0 } | ||
|
|
||
| :root { | ||
| --c-background: #fff5f5; | ||
| --c-text: #d32f2f; | ||
|
|
||
| --button-border: 1px solid var(--c-text); | ||
| --button-background: transparent; | ||
| --button-color: var(--c-text); | ||
|
|
||
| --button-disabled-border: 1px solid var(--c-text); | ||
| --button-disabled-background: transparent; | ||
| --button-disabled-color: var(--c-text); | ||
|
|
||
| --button-hover-border: 1px solid var(--c-text); | ||
| --button-hover-background: var(--c-text); | ||
| --button-hover-color: var(--c-background); | ||
| } | ||
|
|
||
| .errorContent { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 16px; | ||
| align-items: center; | ||
| justify-content: center; | ||
| text-align: center; | ||
|
|
||
| width: 100%; | ||
| height: 100%; | ||
|
|
||
| padding: 24px; | ||
| box-sizing: border-box; | ||
|
|
||
| background: #fff5f5; | ||
| color: #d32f2f; | ||
|
|
||
| border: 1px solid #f5c2c7; | ||
| border-radius: 12px; | ||
|
|
||
| background: var(--c-background); | ||
| color: var(--c-text); | ||
| font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, sans-serif; | ||
| font-size: 14px; | ||
| line-height: 1.5; | ||
| font-weight: 500; | ||
| } | ||
|
|
||
| .${RELOAD_BUTTON_CLASS} { | ||
| padding: 8px 24px; | ||
| border: 1px solid #d32f2f; | ||
| border-radius: 8px; | ||
| background: transparent; | ||
| color: #d32f2f; | ||
| font: inherit; | ||
| cursor: pointer; | ||
| border: var(--button-border); | ||
| background: var(--button-background); | ||
| color: var(--button-color); | ||
| } | ||
| .${RELOAD_BUTTON_CLASS}:hover { | ||
| background: #d32f2f; | ||
| color: #fff5f5; | ||
|
|
||
| .${RELOAD_BUTTON_CLASS}:disabled { | ||
| border: var(--button-disabled-border); | ||
| background: var(--button-disabled-background); | ||
| color: var(--button-disabled-color); | ||
| cursor: progress; | ||
| opacity: 0.75; | ||
| } | ||
|
|
||
| .${RELOAD_BUTTON_CLASS}:not(:disabled):hover { | ||
| border: var(--button-hover-border); | ||
| background: var(--button-hover-background); | ||
| color: var(--button-hover-color); | ||
| } | ||
| </style> | ||
| ${integratorStyles} | ||
| </head> | ||
| <body> | ||
| <div class="errorContent"> | ||
| <span>Couldn't load the widget. Please try again later.</span> | ||
| <p>Couldn't load the page. Please, try again later.</p> | ||
|
|
||
| <button class="${RELOAD_BUTTON_CLASS}">Retry</button> | ||
| <button type="button" class="${RELOAD_BUTTON_CLASS}">${RETRY_BUTTON_LABEL}</button> | ||
| </div> | ||
| <script> | ||
| document.addEventListener('DOMContentLoaded', () => { | ||
| const button = document.querySelector('.${RELOAD_BUTTON_CLASS}'); | ||
|
|
||
| if (!button) return; | ||
|
|
||
| button.addEventListener('click', () => { | ||
| button.disabled = true; | ||
| button.textContent = '${RETRY_BUTTON_LOADING_LABEL}'; | ||
| window.parent.postMessage({ key: '${WIDGET_TRANSPORT_KEY}', method: '${WIDGET_LOAD_RETRY}' }, '*'); | ||
| }); | ||
| }); | ||
| </script> | ||
| </body> | ||
| </html>` | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether the border and border radius work in the integrators page depends on how the iframe is being rendered/placed in the page, so I've removed them just to be safe.