-
-
Notifications
You must be signed in to change notification settings - Fork 46
feat: Implement From<DbFieldValue> for Non primitive types
#562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ElijahAhianyo
wants to merge
16
commits into
master
Choose a base branch
from
elijah/limitedstring-option
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5c898f3
Implement `From<DbFieldValue>` for `Option<LimitedString<LIMIT>>`
ElijahAhianyo 31ceb0f
add unit test
ElijahAhianyo 1b38cd6
clippy fix
ElijahAhianyo 85836e8
write tests to actually call fns
ElijahAhianyo 51bd3ce
increase coverage
ElijahAhianyo b257b05
add more impl
ElijahAhianyo 8c4714d
Merge branch 'master' into elijah/limitedstring-option
ElijahAhianyo 1bab4b0
add tests
ElijahAhianyo 07c5a38
clippy fix
ElijahAhianyo c22777e
Merge branch 'master' into elijah/limitedstring-option
ElijahAhianyo dd47b7b
Potential fix for pull request finding 'CodeQL / Hard-coded cryptogra…
ElijahAhianyo 91371ce
Merge branch 'master' into elijah/limitedstring-option
ElijahAhianyo 3d5d2ab
fix ci
ElijahAhianyo bbb3edf
fix feature-combination CI
ElijahAhianyo 0aa8ef1
fix for PasswordHash
ElijahAhianyo 786e49c
final fix
ElijahAhianyo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very arguable that duplication of impl code can be abstracted into the
impl_db_fieldmacro. I'm still accessing this. My main concern is prioritizing code readability and reducing the number of special cases when improving the macro to support most cases.