ICS20: Correction to the denom in the sequence diagram#1229
Open
ivan-gavran wants to merge 3 commits intocosmos:mainfrom
Open
ICS20: Correction to the denom in the sequence diagram#1229ivan-gavran wants to merge 3 commits intocosmos:mainfrom
ivan-gavran wants to merge 3 commits intocosmos:mainfrom
Conversation
chipshort
reviewed
May 26, 2025
Contributor
chipshort
left a comment
chipshort
left a comment
There was a problem hiding this comment.
Nice finding, I just stumbled upon the same thing.
I'm not a maintainer here, but some suggestions inline.
Co-authored-by: Christoph Otter <chipshort@tutanota.com>
Author
Thanks for paying such a close attention! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses one imprecision in ICS20 README that may cause confusion in otherwise very helpful sequence diagram example.
In the diagram illustrating multi-chain token transfer, there is a mistake in the denoms (in the last transaction):
Bshould be burningtransfer/ChannelToA/denom(instead oftransfer/ChannelToB/transfer/ChannelToA/denom)Bshould be sending toAtransfer/ChannelToA/denom(instead oftransfer/ChannelToB/transfer/ChannelToA/denom)Ashould be unlockingdenom(instead oftransfer/channelToA/denom)