fix: Fix incorrect validation in chanCloseFrozen function in README.md#1198
Open
mdqst wants to merge 1 commit intocosmos:mainfrom
Open
fix: Fix incorrect validation in chanCloseFrozen function in README.md#1198mdqst wants to merge 1 commit intocosmos:mainfrom
mdqst wants to merge 1 commit intocosmos:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed an issue in the
chanCloseFrozenfunction where the validationabortTransactionUnless(hopsLength === 1)doesn't align with the intended logic.Since this function is designed to handle multi-hop connections, the check should ensure that
connectionHopslength is greater than 1, not equal to 1.This change ensures the function works correctly for its intended use case.