small PR to create an enum from constants - #556
Merged
Conversation
|
Test Results 466 files 466 suites 22s ⏱️ Results for commit c9232b5. |
abdessamad-abdoun
approved these changes
Aug 26, 2026
…ser.AccessRightDefinition
…ad code and redundant imports
remiceres
force-pushed
the
acces-right-enum
branch
from
August 27, 2026 08:48
c9232b5 to
f6f22c5
Compare
remiceres
approved these changes
Aug 27, 2026
remiceres
left a comment
remiceres
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Rebased on feature/corese-next, cleaned up AccessMode enum, modernized switch expressions, and cleaned dead code.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
created an enum "AccessModes" in
core.sparql.triple.parser.AccessRightfrom constants GT_MODE, EQ_MODE, BI_MODEcore.sparql.triple.parser.AccessRightDefinition