Add minimal next SELECT/ASK executor - #491
Merged
abdessamad-abdoun merged 5 commits intoJul 16, 2026
Merged
Conversation
|
Test Results 436 files 436 suites 34s ⏱️ Results for commit 513fcb4. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
This PR introduces the first end-to-end “next pipeline” execution path for minimal SPARQL SELECT and ASK queries, wiring together the next parser, AST bridge, KGRAM-next runtime, and StorageManagerProducer backed by a StorageManager.
Changes:
- Added
NextSparqlPipelineExecutorto executeSELECT/ASKthrough the next pipeline (parser → AST → KGRAM → storage). - Introduced reusable KGRAM execution collaborators (
SparqlKgramEvaluator,RdfTermMatcher) for minimal graph-pattern execution. - Added end-to-end tests for simple SPO and joined BGP queries using
MemoryStorageManager, and updatedStorageManagerProducertests to use the shared evaluator/matcher.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/fr/inria/corese/core/next/query/kgram/tool/StorageManagerProducerTest.java | Updates tests to use the shared evaluator/matcher and a test edge implementation. |
| src/test/java/fr/inria/corese/core/next/query/impl/sparql/execution/NextSparqlPipelineExecutorTest.java | New end-to-end tests validating SELECT/ASK execution over MemoryStorageManager. |
| src/main/java/fr/inria/corese/core/next/query/kgram/tool/StorageManagerProducer.java | Improves docs and adjusts unsupported-feature error signaling. |
| src/main/java/fr/inria/corese/core/next/query/kgram/execution/SparqlKgramEvaluator.java | New minimal KGRAM evaluator placeholder for SPARQL execution scope. |
| src/main/java/fr/inria/corese/core/next/query/kgram/execution/RdfTermMatcher.java | New strict RDF-term matcher used during KGRAM pattern matching. |
| src/main/java/fr/inria/corese/core/next/query/kgram/execution/package-info.java | New package documentation for the execution collaborators. |
| src/main/java/fr/inria/corese/core/next/query/impl/sparql/execution/NextSparqlPipelineExecutor.java | New internal executor wiring the full next pipeline to storage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
This reverts commit 0aca181.
|
remiceres
marked this pull request as ready for review
July 16, 2026 10:37
abdessamad-abdoun
approved these changes
Jul 16, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #490.
Adds a minimal internal executor for SELECT and ASK queries through the next pipeline.
This connects the next parser, AST bridge, KGRAM, StorageManagerProducer, and StorageManager. It also adds reusable KGRAM execution collaborators and end-to-end tests for simple SPO and joined BGP queries.
Checks: