Feature/335 property path parser and ast - #463
Merged
abdessamad-abdoun merged 13 commits intoJul 15, 2026
Merged
Conversation
prbblrypier
added
the
Refactoring
MaillPierre
force-pushed
the
feature/335-property-path-parser-and-ast
branch
from
June 22, 2026 11:36
2890f06 to
523b180
Compare
Contributor
|
I did a rebase and added the visitor pattern to the new asts |
MaillPierre
removed their request for review
June 22, 2026 11:36
MaillPierre
approved these changes
Jun 22, 2026
| * Creates a fresh anonymous blank node label for expanded BGP triples. | ||
| */ | ||
| public TermAst newAnonymousBlankNode() { | ||
| return iri("_:b" + anonymousBlankNodeCounter++); |
Contributor
There was a problem hiding this comment.
Please use fr.inria.corese.core.next.data.impl.io.common.IOConstants#BLANK_NODE_PREFIX in case we want to config it later
|
Test Results 433 files 433 suites 20s ⏱️ Results for commit 407fae3. ♻️ This comment has been updated with latest results. |
remiceres
requested changes
Jun 22, 2026
remiceres
left a comment
remiceres
left a comment
Contributor
There was a problem hiding this comment.
The first one only cleans up the style warnings reported by Sonar.
The second one updates the Gradle source set configuration. On my side, the generated ANTLR parser files were not visible in the project, so imports like fr.inria.corese.core.next.impl.parser.antlr.SparqlParser were not resolved correctly in the IDE. This change fixes that locally, but please verify that it also works correctly on your side.
| /** | ||
| * Creates a fresh anonymous blank node label for expanded BGP triples. | ||
| */ | ||
| public TermAst newAnonymousBlankNode() { |
Contributor
There was a problem hiding this comment.
This generates fresh blank nodes with labels like _:b0. That can collide with user-written blank node labels and make two different nodes become equal in the AST.
@Test
void generatedBlankNodeShouldNotCollideWithUserBlankNodeLabel() {
SparqlParser parser = newParserDefault();
QueryAst ast = parser.parse("""
PREFIX ex: <http://example.org/>
SELECT * WHERE {
_:b0 ex:link [ ex:p ?o ] .
}
""");
BgpAst bgp = whereBgp(ast);
assertEquals(2, bgp.triples().size());
TriplePatternAst inner = bgp.triples().getFirst();
TriplePatternAst outer = bgp.triples().get(1);
assertInstanceOf(IriAst.class, outer.subject());
assertInstanceOf(IriAst.class, outer.object());
assertNotEquals(outer.subject(), outer.object());
assertNotEquals(outer.subject(), inner.subject());
}
prbblrypier
force-pushed
the
feature/335-property-path-parser-and-ast
branch
from
July 8, 2026 14:23
523b180 to
cb281a5
Compare
…loads Use PathAst as the predicate type in triple patterns, with TriplePatternAst.of for simple terms and addTriple overloads for path and term predicates. Extend VariableScopeAnalyzer and parser tests for PredicatePathAst wrapping. Co-authored-by: Cursor <cursoragent@cursor.com>
…uilder Walk path/* grammar rules into PathAst nodes and wire BgpFeature to addTriple with composed predicates. Add parser tests for sequence, alternative, modifiers, inverse, and negated property sets. Co-authored-by: Cursor <cursoragent@cursor.com>
…loads Use PathAst as the predicate type in triple patterns, with TriplePatternAst.of for simple terms and addTriple overloads for path and term predicates. Extend VariableScopeAnalyzer and parser tests for PredicatePathAst wrapping. Co-authored-by: Cursor <cursoragent@cursor.com>
prbblrypier
force-pushed
the
feature/335-property-path-parser-and-ast
branch
from
July 8, 2026 14:51
cb281a5 to
e1a7107
Compare
|
|
remiceres
self-requested a review
July 9, 2026 15:32
Contributor
|
Strengthened SPARQL property path parser/AST tests (precedence, inverse paths, negated sets) and updated NegatedPropertySetPathAst to reject nulls. |
remiceres
approved these changes
Jul 10, 2026
|
abdessamad-abdoun
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ajout du support des property paths SPARQL 1.1 dans le parser next.
Introduction des PathAst et fait porter le prédicat par PathAst dans TriplePatternAst
Mapping la grammaire ANTLR dans SparqlAstBuilder
Production des triples avec prédicats path dans BgpFeature.exitTriplesSameSubjectPath
et quelques corrections
fix build pour Gradle 9.1