Skip to content

feat: add well known deployment problems#111

Merged
fzipi merged 9 commits into
mainfrom
add-known-problems-page
May 7, 2026
Merged

feat: add well known deployment problems#111
fzipi merged 9 commits into
mainfrom
add-known-problems-page

Conversation

@fzipi

@fzipi fzipi commented Feb 12, 2024

Copy link
Copy Markdown
Member

No description provided.

@RedXanadu

RedXanadu commented Feb 12, 2024

Copy link
Copy Markdown
Member

Can we combine this with the 'Known issues' page? It feels a little redundant to have two pages on the same topic, known issues and known problems. Or maybe we retire one or update one?

@fzipi

fzipi commented Feb 13, 2024

Copy link
Copy Markdown
Member Author

Yes, we can, and we should. Let me push the change.

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi fzipi force-pushed the add-known-problems-page branch from 6e97354 to 098f7ba Compare February 13, 2024 21:30
@fzipi

fzipi commented Feb 13, 2024

Copy link
Copy Markdown
Member Author

@RedXanadu Moved to known issues. Also, moved from bullet points to titles, so they can be referenced easily from other places.

@fzipi fzipi requested a review from RedXanadu February 22, 2024 19:09
@fzipi

fzipi commented Feb 25, 2024

Copy link
Copy Markdown
Member Author

@RedXanadu Can you review this one now?

Comment thread content/operation/known_issues.md Outdated
@RedXanadu

RedXanadu commented Feb 26, 2024

Copy link
Copy Markdown
Member

The diff is significant... I thought this was just adding some new bullet points to the list, that would be an easy win and quick to review 😅 I'll review when I can.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Dec 4, 2024

Copy link
Copy Markdown

Deploying crs-documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: bbaf926
Status: ✅  Deploy successful!
Preview URL: https://63280a1f.documentation-km5.pages.dev
Branch Preview URL: https://add-known-problems-page.documentation-km5.pages.dev

View logs

@EsadCetiner

Copy link
Copy Markdown
Member

@fzipi Are you able to pick this PR back up and resolve the open issues? I'll try and review this and get it merged.

Comment thread content/operation/known_issues.md Outdated

@EsadCetiner EsadCetiner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look fine to me. Can you resolve the merge conflicts so I can approve?

@fzipi

fzipi commented May 2, 2026

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

# Conflicts:
#	content/7-known-issues/_index.md

Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>

Copilot AI commented May 2, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved in commit 06aa561. The conflict was in content/7-known-issues/_index.md where main's restructured docs (using bullet points/notice blocks) diverged from the PR's H3 heading format. Kept the H3 heading format (consistent with the rest of the file) and integrated the PR's unique "Webserver returns error after CRS install" section.

Signed-off-by: Felipe Zipitria <felipe.zipitria@owasp.org>
@fzipi

fzipi commented May 3, 2026

Copy link
Copy Markdown
Member Author

@EsadCetiner Conflicts solved.

@EsadCetiner EsadCetiner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EsadCetiner

Copy link
Copy Markdown
Member

@fzipi is this ready to merge?

@fzipi

fzipi commented May 7, 2026

Copy link
Copy Markdown
Member Author

It is. Merging.

@fzipi fzipi merged commit 7132eb9 into main May 7, 2026
2 checks passed
@fzipi fzipi deleted the add-known-problems-page branch May 7, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants