A few CI patches#2516
Conversation
Nothing is using this; our unit tests don't change uids and most of our testing is in VMs. Dropping this makes it easier to run the scripts outside of CI.
Let's do a build with clang as a cleanly separate context instead of serially; and also do it unconditionally. This is prep for turning on more `-Werror` flow in both cases, and also using clang `scan-build` in CI.
The way this tries to replace the system Rust is hacky and actually I realized belatedly I may have broken it recently; basically `installdeps.sh` re-adds the system one, and it's hard to be sure with our current buildsystem we're using the newer one from `$PATH`. What we really want to do here is use a CentOS8 buildroot, which will automatically enforce this in a better way along with solving other problems. But right now we've broken that because libdnf requires a too-new libmodulemd. So let's just rely on the Fedora rust for now.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, lucab The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is unfortunate. I agree having a CentOS 8 buildroot here would be better, though until then I think we should keep the MSRV codified and verified and manually bumped. Even if we agree to run ahead of RHEL's Rust for a bit, if we don't do any tracking, then it makes planning future rebases much harder because there's no guarantee of what our true MSRV is and how it corresponds to RHEL. Thoughts on adding it back?
Hmm, we used to have |
|
(And sorry for bringing this up now! I must have missed this PR.) |
5 participants
ci: Drop testuser creation
Nothing is using this; our unit tests don't change uids and
most of our testing is in VMs.
Dropping this makes it easier to run the scripts outside of CI.
ci: Split clang into separate script, run it in CoreOS CI
Let's do a build with clang as a cleanly separate context
instead of serially; and also do it unconditionally. This
is prep for turning on more
-Werrorflow in both cases,and also using clang
scan-buildin CI.ci: Drop custom msrv checking
The way this tries to replace the system Rust is hacky and
actually I realized belatedly I may have broken it recently; basically
installdeps.shre-adds the system one, and it's hard to be surewith our current buildsystem we're using the newer one from
$PATH.What we really want to do here is use a CentOS8 buildroot,
which will automatically enforce this in a better way along
with solving other problems. But right now we've broken
that because libdnf requires a too-new libmodulemd.
So let's just rely on the Fedora rust for now.